Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): update Skia #16901

Merged
merged 1 commit into from
Feb 11, 2025
Merged

feat(mobile): update Skia #16901

merged 1 commit into from
Feb 11, 2025

Conversation

Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Feb 10, 2025

Description

Update Skia to latest version, this might solve some crashes

Related Issue

Resolve

Screenshots:

@Nodonisko Nodonisko requested a review from a team as a code owner February 10, 2025 10:39
Copy link

coderabbitai bot commented Feb 10, 2025

Walkthrough

The pull request updates the version of the @shopify/react-native-skia dependency from ^1.5.10 to ^1.11.6 across multiple package.json files within different parts of the suite-native project. This change is applied to the @suite-native/app, @suite-native/atoms, @suite-native/firmware, @suite-native/graph, @suite-native/icons, @suite-native/module-accounts-import, @suite-native/react-native-graph, @suite-native/receive, and @suite-native/transactions packages. No other modifications to dependencies, scripts, or configurations have been made in any of the files. The update indicates a shift to a newer version of the dependency that may include additional features, performance improvements, or bug fixes.

Suggested labels

mobile

Suggested reviewers

  • matejkriz
  • mroz22
  • szymonlesisz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45d8cbb and a34b63d.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (9)
  • suite-native/app/package.json (1 hunks)
  • suite-native/atoms/package.json (1 hunks)
  • suite-native/firmware/package.json (1 hunks)
  • suite-native/graph/package.json (1 hunks)
  • suite-native/icons/package.json (1 hunks)
  • suite-native/module-accounts-import/package.json (1 hunks)
  • suite-native/react-native-graph/package.json (1 hunks)
  • suite-native/receive/package.json (1 hunks)
  • suite-native/transactions/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: check-project-or-issue
  • GitHub Check: build-deploy
  • GitHub Check: build-deploy
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: EAS Update
  • GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: build
  • GitHub Check: transport-e2e-test
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: prepare_android_test_app
  • GitHub Check: build-web
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: build-web
  • GitHub Check: test
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (9)
suite-native/react-native-graph/package.json (1)

14-14: Dependency Version Update: @shopify/react-native-skia

The dependency version has been updated to ^1.11.6 to align with the PR objectives of upgrading Skia. Please verify in integration testing that the new version does not introduce any unexpected breaking changes or behavioral differences.

suite-native/icons/package.json (1)

14-14: Dependency Version Update: @shopify/react-native-skia

The upgrade to ^1.11.6 is applied consistently and supports the overall mobile enhancement goals. It is recommended to review the release notes of Skia to ensure that any changes are accounted for in this package.

suite-native/firmware/package.json (1)

16-16: Dependency Version Update: @shopify/react-native-skia

The @shopify/react-native-skia dependency has been updated to ^1.11.6. Since firmware components may have stricter compatibility requirements, double-check that this upgrade does not affect critical rendering or performance aspects within this package.

suite-native/atoms/package.json (1)

18-18: Dependency Version Update: @shopify/react-native-skia

The dependency has been updated to ^1.11.6, which is in line with the PR’s aim. Ensure that all components in the atoms package that interact with Skia continue to work as expected after the upgrade.

suite-native/receive/package.json (1)

17-17: Dependency Version Update: @shopify/react-native-skia

The update to ^1.11.6 is applied here as well. Please verify that any integration or usage of Skia within the receive package is compatible with this newer version, and consider reviewing any breaking changes introduced by the update.

suite-native/graph/package.json (1)

18-18: Updated Skia Dependency Version

The dependency @shopify/react-native-skia has been updated from ^1.5.10 to ^1.11.6 here. This change is consistent with similar updates across the repository. Please verify that the new version's breaking changes (if any) have been reviewed and that integration tests cover the updated functionality.

suite-native/transactions/package.json (1)

18-18: Skia Version Bump Validation

The dependency update to @shopify/react-native-skia as ^1.11.6 is correctly applied in this file. Ensure that this upgrade meets all compatibility requirements for the transactions module and that any new features or changes in the Skia library are accounted for during integration.

suite-native/module-accounts-import/package.json (1)

20-20: Consistent Skia Dependency Upgrade

The update of @shopify/react-native-skia to ^1.11.6 in this module aligns it with the other packages. It’s important to check that any changes in the Skia API from the previous version are handled appropriately within the module’s usage.

suite-native/app/package.json (1)

35-35: Skia Dependency Updated in App Package

The dependency @shopify/react-native-skia has been updated to ^1.11.6, ensuring consistency with the overall project updates. Please confirm that this new version is fully compatible with the Expo configurations and other related dependencies used in the mobile app build.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Nodonisko Nodonisko added the mobile Suite Lite issues and PRs label Feb 10, 2025
@PeKne PeKne merged commit 636b304 into develop Feb 11, 2025
77 of 79 checks passed
@PeKne PeKne deleted the feat/upgrade-skia branch February 11, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

2 participants