chore(connect): update device authenticity config #16903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trezor-ci
added
the
no-project
WalkthroughThe change updates the flag used within the Suggested reviewers
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
scripts/ci/check-connect-data.ts (2)
30-36: Consider enhancing error handling and adding request timeout.The fetch implementation could be more robust with:
- Request timeout to prevent hanging on slow responses
- More descriptive error messages including HTTP status codes
Consider this enhancement:
const fetchJSON = async (url: string) => { - const response = await fetch(url); + const controller = new AbortController(); + const timeout = setTimeout(() => controller.abort(), 30000); // 30s timeout + try { + const response = await fetch(url, { signal: controller.signal }); + if (!response.ok) { + throw new Error(`Failed to fetch ${url}: ${response.status} - ${response.statusText}`); + } + return response.json(); + } finally { + clearTimeout(timeout); + } - if (!response.ok) { - throw new Error(`Failed to fetch ${url}: ${response.statusText}`); - } - return response.json(); };
186-188: Consider enhancing error handling with specific error types.The current error handling could be more granular to handle different types of failures (network, file system, Git operations) separately.
Consider this pattern:
} catch (error) { - console.error(`Error updating configuration: ${error.message}`); + if (error instanceof TypeError) { + console.error('Network or parsing error:', error.message); + process.exit(1); + } else if (error.code === 'ENOENT') { + console.error('File system error:', error.message); + process.exit(1); + } else { + console.error('Unexpected error:', error.message); + process.exit(1); + } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/ci/check-connect-data.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: build-web
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: build-web
- GitHub Check: e2e-test-suite-web (@group=other, trezor-user-env-unix)
- GitHub Check: e2e-test-suite-web (@group=metadata2, trezor-user-env-unix)
- GitHub Check: e2e-test-suite-web (@group=metadata1, trezor-user-env-unix)
- GitHub Check: e2e-test-suite-web (@group_wallet, trezor-user-env-unix bitcoin-regtest, 1)
- GitHub Check: e2e-test-suite-web (@group_passphrase, trezor-user-env-unix, 1)
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
🔇 Additional comments (2)
scripts/ci/check-connect-data.ts (2)
1-29: LGTM! Well-structured imports and constants.The imports are appropriate for the task, and the constants are well-organized with proper typing. The authenticity paths align with the PR objectives for t2b1, t3t1, and t3b1 firmware versions.
182-182: LGTM! Correct GitHub CLI flag update.The change from
--add-labelto--labelaligns with the current GitHub CLI command syntax.
|
This was a test. |
karliatto
deleted the
chore/update-device-authenticity-config-1b6b7e24ea6955daf4b62821cf387df33b0fe8f816a3228107350a309924d525
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trezor/connect check data for device Authenticity
This is an automatically created PR.