Skip to content

chore(suite-desktop): add coins deprecation to 25.2 release notes#16904

Merged
peter-sanderson merged 1 commit intodevelopfrom
chore/rls-update
Feb 10, 2025
Merged

chore(suite-desktop): add coins deprecation to 25.2 release notes#16904
peter-sanderson merged 1 commit intodevelopfrom
chore/rls-update

Conversation

@MiroslavProchazka
Copy link
Copy Markdown
Contributor

Updating release notes to reflect that we are dropping support of several coins in the 25.2 release

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 10, 2025

Walkthrough

The changes update the release notes in the suite-desktop package by adding a new line that deprecates the support for Bitcoin Gold, Dash, Vertcoin, Namecoin, and Digibyte. The new message informs users that these cryptocurrencies will no longer be supported within the Suite, but they will remain available through Firmware and third-party applications. The release notes continue to outline enhancements related to security, transaction details, user interface improvements, and transaction decoding, with the deprecation message being the primary addition in this update.

Possibly related PRs

Suggested labels

release

Suggested reviewers

  • Hermez-cz
  • komret

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/suite-desktop/releaseNotes/release-notes.md (1)

12-12: Clarify the Deprecation Messaging

The new bullet clearly informs users about the deprecation of support for several coins; however, the phrasing could benefit from added clarity. Consider specifying that "native support" in the Suite is being deprecated (rather than implying that overall support is removed) and mention the version (i.e., 25.2) explicitly if that is helpful for user context. This could help avoid any potential confusion since the note also states that these coins will remain available in Firmware and via third-party applications.

For example, you might reword the line as follows:

-   Suite is deprecating support for Bitcoin Gold, Dash, Vertcoin, Namecoin, and Digibyte; however, these coins will continue to be supported in Firmware and can still be accessed through third-party applications.
+   Suite is deprecating native support for Bitcoin Gold, Dash, Vertcoin, Namecoin, and Digibyte as of release 25.2; these coins will still be available via Firmware and through third-party applications.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45d8cbb and 206e259.

📒 Files selected for processing (1)
  • packages/suite-desktop/releaseNotes/release-notes.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: build-web
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)

@peter-sanderson peter-sanderson merged commit d8d6d7a into develop Feb 10, 2025
@peter-sanderson peter-sanderson deleted the chore/rls-update branch February 10, 2025 11:11
@bosomt
Copy link
Copy Markdown
Contributor

bosomt commented Feb 10, 2025

QA OK

image

Info:

  • Suite version: desktop 25.2.1 (4b92a09)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/25.2.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T2T1 2.8.8 regular (revision 592590cf66a9b62dfeee7e4d2afb6e01005e5b2c)
  • Transport: BridgeTransport 3.0.0-bundled.25.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants