Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdin translations update #16911

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

trezor-ci
Copy link
Contributor

Automatically generated PR for updating crowdin translations.

@trezor-ci trezor-ci added the translations Improvement of derived (non-ENG) copy label Feb 10, 2025
@MiroslavProchazka MiroslavProchazka added the no-project This label is used to specify that PR doesn't need to be added to a project label Feb 10, 2025
Copy link

coderabbitai bot commented Feb 10, 2025

Walkthrough

This update introduces several new translation entries and makes minor text adjustments across multiple localization files and support messages. The English and LoL translation files now include keys for various transaction management actions such as cancelling transactions, handling errors when transactions are already confirmed, and providing staking reward information along with related tooltips and badges. The LoL file additionally includes a key for indicating waiting time for rewards. In the Portuguese translation file, a punctuation correction was applied to ensure consistency in the backup subheading. Moreover, the support messages file was updated to adjust the wording and punctuation of error messages and notifications, ensuring consistency in text presentation without affecting the underlying functionality.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e03d0c and 5b16bd0.

📒 Files selected for processing (4)
  • packages/suite-data/files/translations/en.json (7 hunks)
  • packages/suite-data/files/translations/lol.json (7 hunks)
  • packages/suite-data/files/translations/pt.json (1 hunks)
  • packages/suite/src/support/messages.ts (3 hunks)
✅ Files skipped from review due to trivial changes (2)
  • packages/suite/src/support/messages.ts
  • packages/suite-data/files/translations/pt.json
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: check-project-or-issue
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: build-web
  • GitHub Check: build-web
🔇 Additional comments (16)
packages/suite-data/files/translations/lol.json (6)

445-452: Translation Key Updates for Transaction Cancellation Messages
The translation keys related to transaction cancellation—covering the button label, error message (for already mined transactions), fee info, header, notice, and follow-up instruction—have been updated with new Crowdin identifiers. Please ensure that these keys are consistently referenced throughout the codebase and that their counterparts in other localization files (e.g., en.json) are synchronized with these changes.


1464-1465: Updated Replace-by-Fee Error Messages
The keys TR_REPLACE_BY_FEE_FAILED_ALREADY_MINED and TR_REPLACE_BY_FEE_FAILED_ALREADY_MINED_DESCRIPTION now contain new Crowdin identifiers. Verify that these messages appropriately describe the state when a replace-by-fee attempt fails due to the transaction already being mined, and that any references to these keys in the application have been updated.


1475-1476: New Reward Message Translation Keys
The keys TR_REWARD and TR_REWARDS have been updated with new Crowdin identifiers. Ensure that these messages meet the context requirements wherever reward notifications or related UI elements are displayed, and that they are consistent across all translation files.


1712-1712: Staking Refresh Rewards Tooltip Update
The translation key TR_STAKE_REFRESH_REWARDS_TOOLTIP now uses a new identifier. Confirm that the tooltip text is accurate and that the updated key is properly referenced within the staking module’s UI components.


1716-1718: Updated Staking Rewards Messaging
The keys related to staking rewards have been updated as follows:

  • TR_STAKE_REWARDS_ARE_EMPTY
  • TR_STAKE_REWARDS_BADGE (which now includes a {count} placeholder)
  • TR_STAKE_REWARDS_TOOLTIP (which now includes count={count})

Please verify that these placeholders are correctly handled in the UI and that the messages accurately inform the user when no rewards are available or when displaying rewards details.


1745-1745: Staking Wait-to-Check Rewards Message Update
The TR_STAKE_WAIT_TO_CHECK_REWARDS key has been updated with a new Crowdin identifier and includes a {count} placeholder. Make sure that the placeholder is correctly replaced at runtime and that the message clearly communicates the waiting period for checking rewards in the staking process.

packages/suite-data/files/translations/en.json (10)

37-37: Added translation key for destination tag guidance.
The new key "DESTINATION_TAG_GUIDE_LINK": "What is this?" provides users with an inline help link for the destination tag feature. Please verify that the phrasing and tone match other tooltips in the UI.


445-452: New translation entries for transaction cancellation.
The added keys for canceling transactions – including "TR_CANCEL_TX", "TR_CANCEL_TX_BUTTON", "TR_CANCEL_TX_FAILED_ALREADY_MINED", "TR_CANCEL_TX_FAILED_ALREADY_MINED_DESCRIPTION", "TR_CANCEL_TX_FEE", "TR_CANCEL_TX_HEADER", "TR_CANCEL_TX_NOTICE", and "TR_CANCEL_TX_RETURN_TO_YOUR_WALLET" – introduce detailed messaging for the cancellation feature. Ensure the language is consistent with similar UX messages throughout the application, and that any placeholders (if later added) are properly handled.


494-494: New translation key for closing a window.
The key "TR_CLOSE_WINDOW": "Close window" is clear and concise. Confirm that its usage in the application aligns with similar call-to-action texts and that the capitalization style is consistent with the rest of the translations.


1464-1465: Updated messaging for replace-by-fee failure.
The keys "TR_REPLACE_BY_FEE_FAILED_ALREADY_MINED": "Replace transaction failed" and
"TR_REPLACE_BY_FEE_FAILED_ALREADY_MINED_DESCRIPTION": "The transaction couldn’t be replaced as it's just been confirmed on the Bitcoin network."
provide explicit user feedback when a transaction cannot be replaced due to its confirmation status. Verify that this phrasing communicates the issue clearly to end users.


1475-1476: Addition of reward terminology.
The new keys "TR_REWARD": "Reward" and "TR_REWARDS": "Rewards" serve to standardize messaging around earnings and benefits. Make sure that these terms are used consistently in all relevant parts of the UI and match the stylistic preferences of the product.


1712-1712: New tooltip for refreshing staking rewards.
The key "TR_STAKE_REFRESH_REWARDS_TOOLTIP": "Refresh your rewards for this account." offers a clear call-to-action for updating displayed rewards. Confirm that the tooltip’s tone and instructional clarity align with other similar tooltips in the suite.


1716-1716: Concise message for empty staking rewards.
The key "TR_STAKE_REWARDS_ARE_EMPTY": "No rewards" succinctly informs the user when no staking rewards are available. Ensure that this message integrates appropriately with the UI’s conditional logic regarding stake reward displays.


1717-1717: Updated badge label for staking rewards epoch.
The key "TR_STAKE_REWARDS_BADGE": "Epoch number {count}" now dynamically inserts the epoch number. Please verify that the {count} placeholder is correctly replaced at runtime and that the message layout remains clear.


1718-1718: Revised tooltip explaining the duration of a Solana epoch.
The key "TR_STAKE_REWARDS_TOOLTIP": "An epoch in Solana is approximately {count, plural, one {# day} other {# days}} long." uses pluralization to explain time duration. Confirm that the ICU message syntax works properly with the localization framework and displays as expected with different {count} values.


1745-1745: New message for wait time before checking rewards.
The key "TR_STAKE_WAIT_TO_CHECK_REWARDS": "Wait up to {count, plural, one {# day} other {# days}} to check your rewards." clearly communicates the expected delay. Please test the plural formatting to ensure that it handles singular and plural cases correctly.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@peter-sanderson peter-sanderson merged commit 5cf6a99 into develop Feb 10, 2025
33 of 34 checks passed
@peter-sanderson peter-sanderson deleted the trezor-ci/crowdin-sync-1739198750 branch February 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-project This label is used to specify that PR doesn't need to be added to a project translations Improvement of derived (non-ENG) copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants