Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect-common): add fw binaries for 2.8.8 and 1.13.0 #16914

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

MiroslavProchazka
Copy link
Contributor

@MiroslavProchazka MiroslavProchazka commented Feb 10, 2025

Following up on trezor/data#125, adding FW binaries for 2.8.8 and 1.13.0

@MiroslavProchazka MiroslavProchazka marked this pull request as ready for review February 10, 2025 16:35
Copy link

coderabbitai bot commented Feb 10, 2025

Walkthrough

The pull request introduces new firmware release entries for two devices. One entry, targeting the Trezor T1B1 device, adds a firmware version [1, 13, 0] with accompanying details including bootloader version [1, 12, 1], minimum firmware and bootloader versions, URLs for standard and Bitcoin-only firmware binaries, fingerprints, a firmware revision identifier, and a changelog noting multisig-related changes, reworked PIN processing, and a QR code display fix for the XPUB. The other entry adds firmware version 2.8.8 for the T2T1 device, detailing bootloader version [2, 1, 8], minimum firmware version [2, 0, 8] and minimum bootloader version [2, 0, 0], along with URLs and fingerprints for both standard and Bitcoin-only binaries, and a changelog addressing issues with the "PIN attempts exceeded" screen and a recovery flow bug involving 33-word mnemonics.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cf6a99 and 95e5c48.

⛔ Files ignored due to path filters (8)
  • packages/connect-common/files/firmware/t1b1/trezor-t1b1-1.12.1-bitcoinonly.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t1b1/trezor-t1b1-1.12.1.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t1b1/trezor-t1b1-1.13.0-bitcoinonly.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t1b1/trezor-t1b1-1.13.0.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t2t1/trezor-t2t1-2.8.7-bitcoinonly.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t2t1/trezor-t2t1-2.8.7.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t2t1/trezor-t2t1-2.8.8-bitcoinonly.bin is excluded by !**/*.bin
  • packages/connect-common/files/firmware/t2t1/trezor-t2t1-2.8.8.bin is excluded by !**/*.bin
📒 Files selected for processing (2)
  • packages/connect-common/files/firmware/t1b1/releases.json (1 hunks)
  • packages/connect-common/files/firmware/t2t1/releases.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: methods / web
  • GitHub Check: methods / core_in_popup
🔇 Additional comments (2)
packages/connect-common/files/firmware/t2t1/releases.json (1)

2-16: New Firmware Entry for Version 2.8.8 is Complete and Consistent.
This newly added JSON object for firmware version [2, 8, 8] contains all the expected fields including:

  • required, version, min_firmware_version, min_bootloader_version, and bootloader_version
  • URL fields for both the standard firmware (url) and the Bitcoin-only variant (url_bitcoinonly)
  • Corresponding fingerprint and fingerprint_bitcoinonly
  • A firmware_revision identifier
  • A detailed changelog covering the fixes for the "PIN attempts exceeded" screen and the 33-word mnemonic recovery bug
    Additionally, the inclusion of the "translations" array is consistent with previous entries. Please verify that the referenced binary files (and their computed fingerprints) exist and match the expected assets.
packages/connect-common/files/firmware/t1b1/releases.json (1)

2-14: New T1B1 Firmware Entry for Version 1.13.0 is Well-Defined.
This new JSON object correctly introduces firmware version [1, 13, 0] with all required properties:

  • It sets required to false and defines the firmware’s version, bootloader version ([1, 12, 1]), and corresponding minimum version requirements.
  • Both the standard and Bitcoin-only firmware binaries are referenced via url and url_bitcoinonly, with their respective fingerprint fields.
  • The firmware_revision is provided and the changelog clearly summarizes the multisig improvements, revised PIN processing, and the fix for displaying the XPUB via QR code.
    Make sure that the binary file paths are correct and that the fingerprints have been properly verified.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@martykan martykan merged commit 6ef1768 into develop Feb 10, 2025
52 checks passed
@martykan martykan deleted the chore/add-fw-2.8.8 branch February 10, 2025 16:44
@bosomt
Copy link
Contributor

bosomt commented Feb 10, 2025

QA OK

image

Info:

  • Suite version: desktop 25.2.1 (4b92a09)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/25.2.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T2T1 2.8.8 regular (revision 592590cf66a9b62dfeee7e4d2afb6e01005e5b2c)
  • Transport: BridgeTransport 3.0.0-bundled.25.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants