Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): use keyboard avoiding view for send screen #16922

Closed
wants to merge 1 commit into from

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Feb 11, 2025

Related Issue

Resolves #16697

@yanascz yanascz added the mobile Suite Lite issues and PRs label Feb 11, 2025
@yanascz yanascz requested a review from a team as a code owner February 11, 2025 11:53
@yanascz yanascz force-pushed the fix/native/send-output-screen-scrolling branch from acd7289 to 91c5669 Compare February 11, 2025 11:54
Copy link

coderabbitai bot commented Feb 11, 2025

Walkthrough

The updates modify two components related to sending functionality. In the SendScreen component, the keyboardDismissMode prop has been removed from the Screen component, keeping the header, footer, and children unchanged. In SendOutputsScreen, the structure is enhanced by wrapping the SendScreen component in a KeyboardAvoidingView. This adjustment includes platform-specific behavior for iOS and Android by adding imports for KeyboardAvoidingView and Platform from react-native, and defining a new screenStyle constant using prepareNativeStyle. The style is applied using the applyStyle function from useNativeStyles. These changes ensure that keyboard interactions are managed more effectively without altering the component interfaces or overall functionality.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 903dd5c and 91c5669.

📒 Files selected for processing (2)
  • suite-native/module-send/src/components/SendScreen.tsx (1 hunks)
  • suite-native/module-send/src/screens/SendOutputsScreen.tsx (5 hunks)
✅ Files skipped from review due to trivial changes (1)
  • suite-native/module-send/src/components/SendScreen.tsx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: EAS Update
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: prepare_android_test_app
🔇 Additional comments (2)
suite-native/module-send/src/screens/SendOutputsScreen.tsx (2)

3-3: LGTM! Necessary imports and styles added for keyboard handling.

The imports and style definition are correctly implemented:

  • KeyboardAvoidingView and Platform imports for platform-specific keyboard handling
  • prepareNativeStyle for consistent styling
  • Minimal screenStyle with flex: 1 for proper KeyboardAvoidingView functionality

Also applies to: 39-39, 70-72


279-316: LGTM! Keyboard handling implemented following React Native best practices.

The KeyboardAvoidingView implementation:

  • Uses appropriate platform-specific behavior (padding for iOS, height for Android)
  • Maintains existing functionality while adding keyboard handling
  • Properly wraps the SendScreen component

Note: The keyboard handling is particularly important for this screen as it contains form fields that might be obscured by the keyboard, especially on smaller devices.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@yanascz
Copy link
Contributor Author

yanascz commented Feb 11, 2025

According to my additional testing, this doesn't fix the issue properly. Scrolling is fixed but some UI glitches arised. Will attempt to fix properly in #16838.

@yanascz yanascz closed this Feb 11, 2025
@yanascz yanascz deleted the fix/native/send-output-screen-scrolling branch February 11, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing scroll on first Send form screen so input is hidden behind the keyboard
1 participant