chore(suite-native): move tokenDefinitionsMiddleware to desktop packages

[TomasJavnicky]

Description

Moving tokenDefinitionsMiddleware from suite-common to suite.

Related Issue

Trying to resolve issue #11454.

Screenshots:

[coderabbitai]

Walkthrough

The pull request implements changes in the middleware configuration and module organization. In the wallet middleware index file, the source of prepareTokenDefinitionsMiddleware is changed from an external package to a local module. The token definitions middleware file now updates its imports, pointing to modules in the suite-common/token-definitions package using absolute paths instead of local paths. Additionally, the index file in the suite-common/token-definitions package has been modified to remove the export for tokenDefinitionsMiddleware, altering its public API. These updates reflect a restructuring of code dependencies and module boundaries within the codebase.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/suite/src/middlewares/wallet/tokenDefinitionsMiddleware.ts (1)

4-6: Consider using package imports instead of relative paths.

The current import paths are quite long and include /src/ which might expose internal implementation details. Consider updating the imports to use the package name instead:

-import { selectNetworkTokenDefinitions } from '../../../../../suite-common/token-definitions/src/tokenDefinitionsSelectors';
-import { getTokenDefinitionThunk } from '../../../../../suite-common/token-definitions/src/tokenDefinitionsThunks';
-import { getSupportedDefinitionTypes } from '../../../../../suite-common/token-definitions/src/tokenDefinitionsUtils';
+import { selectNetworkTokenDefinitions, getTokenDefinitionThunk, getSupportedDefinitionTypes } from '@suite-common/token-definitions';

This would:

• Make the imports more maintainable
• Hide implementation details
• Reduce the risk of path-related issues

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1516375 and 99a891e.

📒 Files selected for processing (3)

• packages/suite/src/middlewares/wallet/index.ts (1 hunks)
• packages/suite/src/middlewares/wallet/tokenDefinitionsMiddleware.ts (1 hunks)
• suite-common/token-definitions/src/index.ts (0 hunks)

💤 Files with no reviewable changes (1)

• suite-common/token-definitions/src/index.ts

🔇 Additional comments (2)

packages/suite/src/middlewares/wallet/index.ts (1)

18-18: LGTM! Import path updated correctly.

The import path change aligns with the PR objective of moving the middleware to the desktop packages while maintaining the existing functionality.

packages/suite/src/middlewares/wallet/tokenDefinitionsMiddleware.ts (1)

10-35: LGTM! Middleware implementation preserved.

The middleware implementation remains unchanged and continues to work correctly with the token definitions functionality from suite-common.