fix(suite-native): Device Setting: return fw button

[BrantalikP]

Description

Related Issue

Resolve #18097 (comment)

Screenshots:

[coderabbitai]

Walkthrough

The changes in this pull request focus on refactoring the way button properties are passed to a firmware update alert within the DeviceFirmwareCard component. The import statements were updated to remove the direct import of the Button component and instead include the InlineAlertBoxProps type from @suite-native/atoms. The firmwareUpdateProps constant is now explicitly typed as InlineAlertBoxProps | undefined. Instead of passing a fully composed Button React element via the rightButton property, the code now provides three separate properties: buttonLabel, onButtonPress, and buttonProps (containing isDisabled and isLoading). The navigation logic and the overall conditions for displaying the firmware update alert remain unchanged, and there are no modifications to the component's exported signature.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ec1e9a and 2ebe187.

📒 Files selected for processing (1)

• suite-native/module-device-settings/src/components/DeviceFirmwareCard.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: prepare_android_test_app
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (3)

suite-native/module-device-settings/src/components/DeviceFirmwareCard.tsx (3)

15-15: Import updated to support the new props pattern.

The import statement has been properly updated to include InlineAlertBoxProps instead of the Button component, which aligns with the new approach of passing button configuration rather than a pre-constructed button element.

---

78-78: Type annotation improves type safety.

Adding the explicit return type InlineAlertBoxProps | undefined to the firmwareUpdateProps function enhances type safety and code readability.

---

95-102: Button configuration pattern is more declarative.

This change refactors how the button is provided to the alert box, moving from passing a complete Button component to providing separate configuration properties. This is a better approach as it:

1. Makes the component more declarative
2. Allows the InlineAlertBox to maintain consistent styling
3. Properly handles loading and disabled states

The navigation functionality is preserved correctly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[matejkriz]

It works fine now 👍