Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests of package (via devtools::check() ) indicates an error and warnings #113

Closed
soriadelva opened this issue Apr 5, 2024 · 3 comments · Fixed by #117
Closed

Tests of package (via devtools::check() ) indicates an error and warnings #113

soriadelva opened this issue Apr 5, 2024 · 3 comments · Fixed by #117
Labels

Comments

@soriadelva
Copy link
Collaborator

soriadelva commented Apr 5, 2024

Devtools::check() indicates an error and warnings with the package in the part where testthat.R is being run. This happens also in the main. Specifically, in test-input_apply_gam.R it gives the following error:

Error in dplyr::select(., smooth, var, data, derivative, se, crit, lower, upper): Can't select columns that don't exist.
✖ Column smooth doesn't exist.

Warnings include warnings of the following type :

  • Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
    ℹ Please use "rank" instead of .data$rank

  • Using an external vector in selections was deprecated in tidyselect 1.1.0.
    ℹ Please use all_of() or any_of() instead.
    Was:
    data %>% select(name_col_taxa)
    Now:
    data %>% select(all_of(name_col_taxa))

Will wait to merge branch with the main until this is solved.

@damianooldoni
Copy link
Collaborator

The reason are breaking changes in the last version of gratia: https://gavinsimpson.github.io/gratia/news/index.html#breaking-changes-0-9-0
I will try to solve this asap.

@damianooldoni
Copy link
Collaborator

Hi @soriadelva 👋
I think I solved this. Could you please check it by installing the trias package from PR #117 and review that PR? Thanks.

@soriadelva
Copy link
Collaborator Author

Hi @soriadelva 👋 I think I solved this. Could you please check it by installing the trias package from PR #117 and review that PR? Thanks.

Works like a charm 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants