Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt code to use gratia #117

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Adapt code to use gratia #117

merged 11 commits into from
Apr 18, 2024

Conversation

damianooldoni
Copy link
Collaborator

@damianooldoni damianooldoni commented Apr 16, 2024 •
edited
Loading

This PR fixes #113 by adapting apply_gam() to the breaking changes in gratia 0.9.0.

  • Adapt function
  • Adapt documentation (if needed)
  • Update tests
  • Minor changes (e.g. tidyselect compliance to avoid deprecation warnings)

@damianooldoni damianooldoni marked this pull request as ready for review April 16, 2024 13:24
@damianooldoni damianooldoni self-assigned this Apr 16, 2024
@damianooldoni
Avoid a note whil checking the pkg
c8cd625 
Select cols via "col_name"
@damianooldoni damianooldoni mentioned this pull request Apr 16, 2024
Closed
@damianooldoni damianooldoni merged commit 8c4cf3f into main Apr 18, 2024
0 of 6 checks passed
@damianooldoni damianooldoni deleted the fix-use-gratia branch April 18, 2024 06:57
@SanderDevisscher SanderDevisscher mentioned this pull request Apr 18, 2024
Merged
@mvarewyck
Copy link
Collaborator

This code update requires gratia (>= 0.9.0) on my side. Would be good to add to DESCRIPTION

@soriadelva
Copy link
Collaborator

This code update requires gratia (>= 0.9.0) on my side. Would be good to add to DESCRIPTION

Thanks for pointing that out, I added it to DESCRIPTION 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soriadelva soriadelva soriadelva approved these changes

Assignees

@damianooldoni damianooldoni

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests of package (via devtools::check() ) indicates an error and warnings
3 participants
@damianooldoni @mvarewyck @soriadelva