-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken example in visualize_pathways_year_level2()
+ level1
#137
Conversation
visualize_pathways_year_level2()
visualize_pathways_year_level2()
+ level1
It is good to have the example running and shoing the output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have also found some other missing dplyr::
😄
I have also solved some check notes and improved a broken example which was in a \dontrun{ }
. I removed the \dontrun{ }
as well.
Another example on the other hand, has been put wrapped in a \dontrun{ }
as it requires internet connection.
During review I noticed that an example in
visualize_pathways_year_level2()
wouldn't work unlessdplyr
was already loaded. I added some extra namespace calls to dplyr.Then, when running the unit tests, these failed because they were using dplyr functions that are not in the
NAMESPACE
without thedplyr::
in front of them.I also switched out some calls to
tidyselect
todplyr
because this was shorter and this might help removing a direct dependency ontidyselect
, altough you'll still be indirectly dependent on it thoughdplyr
of course. I'm not sure if this causes the package to need a certain minimum version ofdplyr
.EDIT: just saw the same for
visualize_pathways_year_level1()