Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for IPv6 redis connections #1257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mittalyashu
Copy link

Closes #

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

While trying to self-host it, I was trying to add a Redis instance as result, I was getting this error in the logs.

[ioredis] Unhandled error event: Error: connect ETIMEDOUT
    at TLSSocket.<anonymous> (/triggerdotdev/node_modules/.pnpm/[email protected]/node_modules/ioredis/built/Redis.js:170:41)
    at Object.onceWrapper (node:events:631:28)
    at TLSSocket.emit (node:events:517:28)
    at Socket._onTimeout (node:net:598:8)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7)

Changelog

By default ioredis set the connection host to IPv4.

The documentation for the family parameter are: https://nodejs.org/docs/latest-v20.x/api/net.html#socketconnectoptions-connectlistener

Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: d308bfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant