Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disabling authentication for local testing #1301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeyaddeeb
Copy link

@zeyaddeeb zeyaddeeb commented Sep 14, 2024

I just want to see if you guys are open to this. I wanted to test locally and auth is sometimes not required

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

[Describe the steps you took to test this change]


Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Sep 14, 2024

⚠️ No Changeset found

Latest commit: 42c8fda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken
Copy link
Member

@zeyaddeeb when you're developing locally you can sign in with any email address using magic link and it doesn't require confirmation. It instantly logs you in. This is based on NODE_ENV being "development":

if (env.NODE_ENV === "development") {

I think this achieves the same as what you want but also allows you to have many accounts which is really useful during development.

@zeyaddeeb
Copy link
Author

I wanted to kill auth all together, any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants