Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support http+unix URLs #473

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

dechamps
Copy link
Contributor

@dechamps dechamps commented Aug 30, 2024

This adds support for Unix socket URLs as a follow-up to Unix socket connection support in #447.

There is no standard for Unix socket URLs, see whatwg/url#577. This PR tries to be consistent with prior art in https://github.com/msabramo/requests-unixsocket.

This adds support for Unix socket URLs as a follow-up to Unix socket
connection support in trim21#447.
@trim21
Copy link
Owner

trim21 commented Aug 31, 2024

it's always http protocol, in fact I don't think we need +http or http+ part in protocol, unix should be enough.

never mind

@trim21 trim21 merged commit 9b60793 into trim21:build/requests Aug 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants