Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Menu for Advanced Chip Functionality #2911

Open
mitch-trimble opened this issue Oct 14, 2024 · 8 comments · May be fixed by #3103
Open

Create a Menu for Advanced Chip Functionality #2911

mitch-trimble opened this issue Oct 14, 2024 · 8 comments · May be fixed by #3103
Assignees
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-chip priority:high Prioritization for this item is high team-e-builder Product E-Builder, Digital Project Delivery division

Comments

@mitch-trimble
Copy link
Collaborator

mitch-trimble commented Oct 14, 2024

Request Requirements

Request

Create a menu component that's similar to the dropdown. Ideally in the future dropdown component will be replaced with this more advanced component. It's a container that opens on click event below the clicked component.

Design

Figma

Updates required

This workflow will allow us to insert other components/objects into a menu that is activated by a chip.

In order to complete this component we need to make a few changes to existing components:

Chips

  • Add option to customize border radius
    • example: Need to be able to do 8px border radius for design
  • Update clear button styling to match new design
    • Split button separating clear action from chip label
    • End result looks like one chip but has two buttons (each hover state shows independently)
      • Label button opens menu/etc
      • Clear button clears selection

Menu

  • Toggle element ID property is required
  • Add option for menu to stay open after selecting from list
    • Add a control: disable-close-onselect. By default it should be false
    • Default this option to current behavior (closes when selecting)
    • Update data filter as selections are made
      • Each selection will reload the data set but the menu should stay open
  • Menu can be closed by clicking outside of menu (elsewhere on screen)
    * Menu should also close when the parent component is clicked again
  • Allow other components to be added inside menu container
    • All form control options are valid for v1
  • Add parent styles to remove rounded corners on components when inserted into menu list within dropdown
    • List item (0 border radius)
    • Others TBD
  • Menu height should be:
    • Maximum of 70vh or 400px
    • Minimum of 40vh or 200px
  • Menu width should be”
    • Minimum of 160px
    • Maximum of 300px

Later Updates:

  • after this work is completed we will iterrate on this component to add a header/footer with actions for clear/close/etc
  • Not required for v1 right now
@mitch-trimble mitch-trimble converted this from a draft issue Oct 14, 2024
@prashanth-offcl prashanth-offcl self-assigned this Oct 14, 2024
@prashanth-offcl prashanth-offcl added external-request Bugs and features reported by individuals from other teams in Trimble team-e-builder Product E-Builder, Digital Project Delivery division modus-chip labels Oct 25, 2024
@enowak1031 enowak1031 moved this from In Progress to Refinement in Modus Web Components Nov 7, 2024
@apaddock
Copy link

apaddock commented Nov 13, 2024

Current possibility: https://codepen.io/cjwinsor/pen/NWZQYxR

@enowak1031
Copy link

Mitch to provide a Figma example.

@enowak1031 enowak1031 changed the title Advanced Chips Create a Menu for Advanced Chip Functionality Nov 13, 2024
@enowak1031 enowak1031 added the priority:high Prioritization for this item is high label Nov 20, 2024
@enowak1031
Copy link

Let's start work on the simple components.

  • list
  • checkbox
  • date & time picker
  • select component
  • switches
  • radios
  • number input
  • slider
  • text input
  • text area
  • autocomplete
  • buttons & button groups
  • icons

We will further iterate to add more advance functionality.

@enowak1031
Copy link

@mitch-trimble Of the components listed which ones should have overwritten styles, including rounded corners (ie. list)

@enowak1031
Copy link

enowak1031 commented Nov 26, 2024

Should we break this issue up based on what control we are supporting? This calls for a separate component, "menu" that can be trigged by any other interaction than a chip. For example: https://atlassian.design/components/menu/examples
https://m2.material.io/components/menus

@enowak1031 enowak1031 moved this from Refinement to In UX in Modus Web Components Dec 4, 2024
@enowak1031
Copy link

We will create a separate issue to tackle the formatting fix of the menu to remove the rounded corners. It's a story we can complete prior to building out the feature.

@ElishaSamPeterPrabhu
Copy link
Collaborator

Closing issues #3095 #3096 by linking it here

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu moved this from Refinement to In Progress in Modus Web Components Jan 13, 2025
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Jan 13, 2025 that will close this issue
13 tasks
@enowak1031 enowak1031 moved this from In Progress to QA in Modus Web Components Jan 13, 2025
@jewel-shajan jewel-shajan moved this from QA to PR Review in Modus Web Components Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-chip priority:high Prioritization for this item is high team-e-builder Product E-Builder, Digital Project Delivery division
Projects
Status: PR Review
Development

Successfully merging a pull request may close this issue.

5 participants