Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to render Table with pre selected rows #1906

Merged

Conversation

leosole-trimble
Copy link
Contributor

@leosole-trimble leosole-trimble commented Nov 22, 2023

Description

References #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit f8d8ce8
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/65689b7b4104f90009e1c55a
😎 Deploy Preview https://deploy-preview-1906--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

aviator-app bot commented Nov 23, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@msankaran0712
Copy link
Contributor

@leosole-trimble Please fix the review comments and test the row selection and inline editing for nested rows on a large dataset before merging the PR. Please check with @coliff or @cjwinsor to review and approve, I will be on leave on Monday.

@leosole-trimble leosole-trimble marked this pull request as ready for review November 30, 2023 14:06
@leosole-trimble leosole-trimble requested review from coliff and a team as code owners November 30, 2023 14:06
msankaran0712
msankaran0712 previously approved these changes Nov 30, 2023
@msankaran0712 msankaran0712 merged commit f2c25d5 into trimble-oss:main Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants