Fix lint/prettier commands for Mac/Linux OS #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the
lint-js
,lint-css
, andprettier
scripts in stencil-workspace'spackage.json
to put quotes around the paths to ensure proper expansion.References #1939
Type of change
How Has This Been Tested?
I ran
npm run lint-js
,npm run lint-css
, andnpm run prettier
in Windows and Ubuntu (via WSL) with the following scenarios:For
lint-js
I addedvar x = 1;
to a file insrc/components/
,src/index.ts
, and a file instorybook/stories/components/*/*.stories.tsx
and ensured each file showed up with eslint errors.For
lint-css
I removed blank spaces between style blocks in files matching the patternsrc/**/*.scss
and observed that after the script ran that the file was fixed, placing the empty line back between the blocks.For
prettier
I removed semi-colons at the end of lines of javascript in files under/src/components
and observed that after the script ran that the semi-colons were re-added. Currently the.prettierignore
file ignores*.stories.tsx
so I did not validate thestorybook/stores/
directory was hit as I did not see any existing files.Checklist