Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint/prettier commands for Mac/Linux OS #1941

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

cjwinsor
Copy link
Contributor

@cjwinsor cjwinsor commented Dec 7, 2023

Description

Updated the lint-js, lint-css, and prettier scripts in stencil-workspace's package.json to put quotes around the paths to ensure proper expansion.

References #1939

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

I ran npm run lint-js, npm run lint-css, and npm run prettier in Windows and Ubuntu (via WSL) with the following scenarios:

For lint-js I added var x = 1; to a file in src/components/, src/index.ts, and a file in storybook/stories/components/*/*.stories.tsx and ensured each file showed up with eslint errors.

For lint-css I removed blank spaces between style blocks in files matching the pattern src/**/*.scss and observed that after the script ran that the file was fixed, placing the empty line back between the blocks.

For prettier I removed semi-colons at the end of lines of javascript in files under /src/components and observed that after the script ran that the semi-colons were re-added. Currently the .prettierignore file ignores *.stories.tsx so I did not validate the storybook/stores/ directory was hit as I did not see any existing files.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cjwinsor cjwinsor requested a review from a team as a code owner December 7, 2023 15:12
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit e11aa32
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/6571e0c411e30e0009a8d972
😎 Deploy Preview https://deploy-preview-1941--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjwinsor
Copy link
Contributor Author

cjwinsor commented Dec 7, 2023

You can see in the checks that it now includes files in src/components when running prettier, which earlier PRs weren't.
image

In previous PRs you'd see
image

@coliff coliff added the devOps Site management, GitHub workflows, etc label Dec 7, 2023
@coliff coliff merged commit 9a2e44a into trimble-oss:main Dec 7, 2023
9 checks passed
@cjwinsor cjwinsor deleted the issue-1939-lint-script-fix branch December 7, 2023 15:27
@coliff coliff added the bug Something is wrong and needs to be addressed label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed devOps Site management, GitHub workflows, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants