Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positives in spellcheck #1943

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Dec 11, 2023

Description

The spellcheck issues were creating noise in PRs so with changes in this PR they are fixed:

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff added 1 1 story point skip-changelog Skip Changelog labels Dec 11, 2023
@coliff coliff requested a review from a team as a code owner December 11, 2023 14:04

This comment was marked as off-topic.

This comment was marked as off-topic.

@coliff coliff enabled auto-merge (squash) December 11, 2023 14:13
@coliff coliff merged commit 2b82dd7 into main Dec 11, 2023
9 checks passed
@coliff coliff deleted the dev/coliff/spellcheck-config-update branch December 11, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point skip-changelog Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants