Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Icon Inconsistent colors and class names #1946

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

coliff
Copy link
Member

@coliff coliff commented Dec 12, 2023

Description

Partial fix for #1889

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Locally with Edge v120 on Windows 11.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff requested a review from a team as a code owner December 12, 2023 13:16
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for modus-webcomponents ready!

Name Link
🔨 Latest commit 1d9cc9c
🔍 Latest deploy log https://app.netlify.com/sites/modus-webcomponents/deploys/65794d0372ccf60008089d25
😎 Deploy Preview https://deploy-preview-1946--modus-webcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff added the bug Something is wrong and needs to be addressed label Dec 12, 2023
@coliff coliff force-pushed the dev/coliff/icon-consistency-fixes branch from 327040e to 402580c Compare December 12, 2023 13:29
@@ -20,7 +20,7 @@ export const IconInfo: FunctionalComponent<IconProps> = (props: IconProps) => (
fill-rule="evenodd"
clip-rule="evenodd"
d="M12 21C16.968 21 21 16.968 21 12C21 7.032 16.968 3 12 3C7.032 3 3 7.032 3 12C3 16.968 7.032 21 12 21ZM11 7H13V9H11V7ZM11 11H13L13 17H11L11 11Z"
fill={props.color ?? '#6A6976'}
fill={props.color ?? 'currentColor'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we not move this to svg?

@coliff coliff marked this pull request as draft December 12, 2023 13:54
@coliff coliff force-pushed the dev/coliff/icon-consistency-fixes branch from 94be467 to f0ea34a Compare December 12, 2023 14:05
@coliff coliff marked this pull request as ready for review December 12, 2023 14:22
@coliff coliff requested a review from msankaran0712 December 12, 2023 14:31
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-ground-0374a1310-1946.centralus.1.azurestaticapps.net

@coliff coliff merged commit 3329652 into main Dec 13, 2023
9 checks passed
@coliff coliff deleted the dev/coliff/icon-consistency-fixes branch December 13, 2023 06:50
@cjwinsor cjwinsor mentioned this pull request Apr 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants