-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Icon Inconsistent colors and class names #1946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for modus-webcomponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
327040e
to
402580c
Compare
@@ -20,7 +20,7 @@ export const IconInfo: FunctionalComponent<IconProps> = (props: IconProps) => ( | |||
fill-rule="evenodd" | |||
clip-rule="evenodd" | |||
d="M12 21C16.968 21 21 16.968 21 12C21 7.032 16.968 3 12 3C7.032 3 3 7.032 3 12C3 16.968 7.032 21 12 21ZM11 7H13V9H11V7ZM11 11H13L13 17H11L11 11Z" | |||
fill={props.color ?? '#6A6976'} | |||
fill={props.color ?? 'currentColor'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we not move this to svg?
Partial fix for #1889
94be467
to
f0ea34a
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-ground-0374a1310-1946.centralus.1.azurestaticapps.net |
msankaran0712
approved these changes
Dec 13, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix for #1889
Type of change
How Has This Been Tested?
Locally with Edge v120 on Windows 11.
Checklist