Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Table: emit row click event #2688

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

leosole-trimble
Copy link
Contributor

@leosole-trimble leosole-trimble commented Jul 10, 2024

Description

Emit a row click event when the user clicks a row (if the cell clicked is not editable)

References #2480

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Added a unit test, and added the event to storybook.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@leosole-trimble leosole-trimble requested a review from coliff as a code owner July 10, 2024 12:18
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4275f66
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66918198e981f80008b66666
😎 Deploy Preview https://deploy-preview-2688--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjwinsor
Copy link
Contributor

@leosole-trimble I Aha! ticket was created for this item and a discussion has started in the comments. https://modus.ideas.aha.io/ideas/MOD-I-95

It would be good to continue that discussion so they understand the full scope of the UX being considered here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants