Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table : update edit mode tab to navigate #2870

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Sep 18, 2024

Description

References

Fixes #2437

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 5b55616
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/674f0ed97e719e00087890f8
😎 Deploy Preview https://deploy-preview-2870--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 42 (🔴 down 5 from production)
Accessibility: 75 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 marked this pull request as draft September 18, 2024 06:59
@prashanthr6383 prashanthr6383 added bug Something is wrong and needs to be addressed and removed bug Something is wrong and needs to be addressed labels Sep 18, 2024
@prashanth-offcl
Copy link
Contributor

@prashanthr6383 Regarding the issue Dateinput field edit mode is not updated when tabbing through cells you can assign handleBlur to onDateInputBlur prop of modus-data-input component.

Apart from the issue you brought up, I see the autocomplete dropdown and date picker dropdown is not appearing as before when I press tab. Can you check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Edit Mode
2 participants