Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chips: Add Trailing Icon #3100

Closed

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Jan 8, 2025

Description

  • Added trailing icon
  • Modified close icon

References
Fixes #3095

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-3100--moduswebcomponents.netlify.app/?path=/story/components-chip--default&args=trailingIcon:alert

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu requested a review from a team as a code owner January 8, 2025 06:16
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 1e68d66
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/677e184003973b0008b28097
😎 Deploy Preview https://deploy-preview-3100--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46 (🔴 down 1 from production)
Accessibility: 75 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff
Copy link
Member

coliff commented Jan 8, 2025

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu marked this pull request as draft January 15, 2025 05:19
@ElishaSamPeterPrabhu
Copy link
Collaborator Author

Closed the PR as the necessary changes are part of the PR #3103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a trailing icon to the chip
2 participants