Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip: Prevent event emit on keydown in disabled state #3106

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Jan 15, 2025

Description

References

This PR fixes

  1. prevents event emit / focus on keyboard navigation
  2. prevents duplicate event emission on pressing enter
  3. adding event emission for space key

Fixes #3105

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-3106--moduswebcomponents.netlify.app/

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@prashanthr6383 prashanthr6383 requested a review from a team as a code owner January 15, 2025 09:34
@prashanthr6383 prashanthr6383 linked an issue Jan 15, 2025 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 95a18f1
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6787810db84e1a0008e8643d
😎 Deploy Preview https://deploy-preview-3106--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52 (🟢 up 9 from production)
Accessibility: 75 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 changed the title 3105 chip disabled chip still emits events and is focusable via tabbing Chip: Prevent event emit on keydown in disabled state Jan 15, 2025
Copy link

@jewel-shajan jewel-shajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed and ready for PR Review.

@coliff coliff merged commit e6450e5 into main Jan 16, 2025
11 checks passed
@coliff coliff deleted the 3105-chip-disabled-chip-still-emits-events-and-is-focusable-via-tabbing branch January 16, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chip: Disabled Chip Still Emits Events and is Focusable via Tabbing
4 participants