Skip to content

Add the toString override to build the role header string #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add the toString override to build the role header string #21

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84cc5fa
Add the toString override to build the role header string
SaravananPrasadh-SP Mar 24, 2025
ff9bf56
Tested the Role property fix
SaravananPrasadh-SP Mar 24, 2025
e74cfac
Support for various types along with NONE, ALL etc
SaravananPrasadh-SP Mar 24, 2025
7229941
Fix for the Role Type generalization
SaravananPrasadh-SP Mar 24, 2025
86bf825
Removing local test Solution from the Committed files
SaravananPrasadh-SP Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions trino-csharp/Trino.Client/ClientSelectedRole.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,10 @@ public ClientSelectedRole Clone()
{
return new ClientSelectedRole(this.RoleType, this.Role);
}

public override string ToString()
{
return Type.ROLE.ToString()+"{"+Role+"}";
Copy link
Member

@stephen-zhao stephen-zhao Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to work regardless of the role type. This impl only works for role type = ROLE. What about NONE and ALL?

Copy link
Author

@SaravananPrasadh-SP SaravananPrasadh-SP Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly me, Thank you!! I fixed it and tested with ROLE and NONE and ALL

Copy link
Author

@SaravananPrasadh-SP SaravananPrasadh-SP Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephen-zhao : Can you please check if the changes look okay?

}
}
}