Migrate JDBC to page source API #25123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
force-pushed
the
raunaq/jdbc-page
branch
4 times, most recently
from
fd8fb98 to
5cc9309
Compare
raunaqmorarka
force-pushed
the
raunaq/jdbc-page
branch
from
5cc9309 to
d35009f
Compare
wendigo
reviewed
Feb 25, 2025
| @@ -119,6 +123,20 @@ else if (javaType == Slice.class) { | |||
| else { | |||
| statement = jdbcClient.buildSql(session, connection, split, (JdbcTableHandle) table, columnHandles); | |||
| } | |||
| pageBuilder = new PageBuilder(columnHandles.stream().map(JdbcColumnHandle::getColumnType).collect(toImmutableList())); | |||
There was a problem hiding this comment.
wrap after .stream() and .map()
wendigo
reviewed
Feb 25, 2025
| @@ -119,6 +123,20 @@ else if (javaType == Slice.class) { | |||
| else { | |||
| statement = jdbcClient.buildSql(session, connection, split, (JdbcTableHandle) table, columnHandles); | |||
| } | |||
| pageBuilder = new PageBuilder(columnHandles.stream().map(JdbcColumnHandle::getColumnType).collect(toImmutableList())); | |||
| resultSetFuture = CompletableFuture.supplyAsync(() -> { | |||
There was a problem hiding this comment.
nit: static import supplyAsync
wendigo
reviewed
Feb 25, 2025
| throw handleSqlException(e); | ||
| } | ||
| finally { | ||
| readTimeNanos.addAndGet(System.nanoTime() - start); |
There was a problem hiding this comment.
nit: static import nanoTime
wendigo
reviewed
Feb 25, 2025
| return false; | ||
| } | ||
|
|
||
| verify(pageBuilder.isEmpty()); |
There was a problem hiding this comment.
, "Expected pageBuilder to be empty"
wendigo
reviewed
Feb 25, 2025
| } | ||
| throw sqlException; | ||
| resultSet = getFutureValue(resultSetFuture); | ||
| verify(resultSet != null, "resultSet is null"); |
There was a problem hiding this comment.
resultSet = requireNonNull(getFutureValue(resultSetFuture), "resultSet is null")
wendigo
reviewed
Feb 25, 2025
| catch (SQLException | RuntimeException e) { | ||
| throw handleSqlException(e); | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
we can calculate this, right?
wendigo
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: