Skip to content

Change to use Chainguard MinIO container #27095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+5 −5
Closed

Change to use Chainguard MinIO container #27095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Minio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class Minio

private static final String MINIO_ACCESS_KEY = "minio-access-key";
private static final String MINIO_SECRET_KEY = "minio-secret-key";
private static final String MINIO_RELEASE = "RELEASE.2025-01-20T14-49-07Z";
private static final String MINIO_RELEASE = "latest";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to use the MinIO container image from Chainguard Containers. Only "latest" is available so I am trying with that.

we need reproducible builds and deterministic tests. My "latest" won't be the same as your "latest".

how do we achieve that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to copy the container into ghcr trino org and tag ourselves?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to pull the image using the hash:

docker pull cgr.dev/chainguard/minio@sha256:66bd82c8fe5e75868ae7d0b2e102d9a0dcf971b270a41bd060a9e6a643476ff8

Maybe this also works with Testcontainers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, that syntax works fine. We should see if we can centralize the version instead of copying it in multiple places.

Copy link
Member Author

@mosabua mosabua Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The digests and all will continue to be avaiable so we can either tag ourselves with something like a date value or we can use hashes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use a single constant of the form

MINIO_IMAGE = "cgr.dev/chainguard/minio@sha256:66bd82c8fe5e75868ae7d0b2e102d9a0dcf971b270a41bd060a9e6a643476ff8";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine with me as well. Should I refactor the code to use a constant along those lines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let’s do that if it’s possible without messing up the module structure. I haven’t looked at the dependencies between these locations.


private static final int MINIO_PORT = 9080; // minio uses 9000 by default, which conflicts with hadoop
private static final int MINIO_CONSOLE_PORT = 9001;
Expand Down Expand Up @@ -69,7 +69,7 @@ public void extendEnvironment(Environment.Builder builder)

private DockerContainer createMinioContainer()
{
DockerContainer container = new DockerContainer("minio/minio:" + MINIO_RELEASE, MINIO_CONTAINER_NAME)
DockerContainer container = new DockerContainer("cgr.dev/chainguard/minio:" + MINIO_RELEASE, MINIO_CONTAINER_NAME)
.withEnv(ImmutableMap.<String, String>builder()
.put("MINIO_ACCESS_KEY", MINIO_ACCESS_KEY)
.put("MINIO_SECRET_KEY", MINIO_SECRET_KEY)
Expand Down
4 changes: 2 additions & 2 deletions ...launcher/src/main/java/io/trino/tests/product/launcher/env/environment/SpoolingMinio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class SpoolingMinio
private static final String MINIO_SPOOLING_CONTAINER_NAME = "spooling-minio";
private static final String MINIO_ACCESS_KEY = "minio-access-key";
private static final String MINIO_SECRET_KEY = "minio-secret-key";
private static final String MINIO_RELEASE = "RELEASE.2025-01-20T14-49-07Z";
private static final String MINIO_RELEASE = "latest";

private static final int MINIO_PORT = 9080; // minio uses 9000 by default, which conflicts with hadoop
private static final int MINIO_CONSOLE_PORT = 9001;
Expand Down Expand Up @@ -95,7 +95,7 @@ private DockerContainer createSpoolingMinioContainer()
throw new UncheckedIOException(e);
}

DockerContainer container = new DockerContainer("minio/minio:" + MINIO_RELEASE, MINIO_SPOOLING_CONTAINER_NAME)
DockerContainer container = new DockerContainer("cgr.dev/chainguard/minio:" + MINIO_RELEASE, MINIO_SPOOLING_CONTAINER_NAME)
.withEnv(ImmutableMap.<String, String>builder()
.put("MINIO_ACCESS_KEY", MINIO_ACCESS_KEY)
.put("MINIO_SECRET_KEY", MINIO_SECRET_KEY)
Expand Down
2 changes: 1 addition & 1 deletion testing/trino-testing-containers/src/main/java/io/trino/testing/containers/Minio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class Minio
{
private static final Logger log = Logger.get(Minio.class);

public static final String DEFAULT_IMAGE = "minio/minio:RELEASE.2024-12-18T13-15-44Z";
public static final String DEFAULT_IMAGE = "cgr.dev/chainguard/minio";
public static final String DEFAULT_HOST_NAME = "minio";

public static final int MINIO_API_PORT = 4566;
Expand Down
Loading