Only warn about DockerContainer log paths when configured

[electrum]

Fix spurious warnings from DockerContainer in product tests when log paths are not configured.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Summary by Sourcery

Refine DockerContainer log handling to suppress unnecessary warnings and clean up outdated null checks.

Bug Fixes:

• Only warn about missing DockerContainer log files when log paths are configured to avoid spurious warnings.

Enhancements:

• Remove redundant null check in DockerContainer.withExposedLogPaths.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refine DockerContainer behavior to avoid spurious warnings when no log paths are configured and remove an unnecessary null check in the log-path exposure method.

File-Level Changes

Change	Details	Files
Remove redundant null check in withExposedLogPaths	Deleted requireNonNull call on this.logPaths	testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/DockerContainer.java
Warn about missing logs only when log paths are set	Modified if-condition to include logPaths.isEmpty() check before warning	testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/DockerContainer.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Copilot]

Pull Request Overview

This PR fixes spurious warnings from DockerContainer in product tests by only emitting log path warnings when log paths are actually configured. The changes ensure that the absence of log files is only reported when logs were expected to be present.

Key Changes:

• Removed unnecessary null check that prevented proper log path configuration
• Modified warning condition to only trigger when log paths are configured but files are missing

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}