Skip to content

Fix handling of dropped base tables for Iceberg MVs #27606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 2 commits into from
Dec 11, 2025
+12 −10
Merged

Fix handling of dropped base tables for Iceberg MVs #27606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1c024
Rename CorruptedTableChange to GoneOrCorruptedTableChange
piotrrzysko Dec 11, 2025
b2df4cf
Fix handling of dropped base tables for Iceberg MVs
piotrrzysko Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3928,13 +3928,10 @@ case FirstChangeSnapshot(Snapshot snapshot) -> {
firstTableChange = firstTableChange
.map(epochMilli -> Math.min(epochMilli, snapshot.timestampMillis()));
}
case UnknownTableChange() -> {
case UnknownTableChange(), GoneOrCorruptedTableChange() -> {
hasStaleIcebergTables = true;
firstTableChange = Optional.empty();
}
case CorruptedTableChange() -> {
return new MaterializedViewFreshness(STALE, Optional.empty());
}
}
}

Expand Down Expand Up @@ -3972,7 +3969,7 @@ else if (strings.size() != 2) {

if (tableHandle == null || tableHandle instanceof CorruptedIcebergTableHandle) {
// Base table is gone or table is corrupted
return new CorruptedTableChange();
return new GoneOrCorruptedTableChange();
}
Optional<Long> snapshotAtRefresh;
if (value.isEmpty()) {
Expand Down Expand Up @@ -4098,7 +4095,7 @@ private static IcebergTableHandle checkValidTableHandle(ConnectorTableHandle tab
}

private sealed interface TableChangeInfo
permits NoTableChange, FirstChangeSnapshot, UnknownTableChange, CorruptedTableChange {}
permits NoTableChange, FirstChangeSnapshot, UnknownTableChange, GoneOrCorruptedTableChange {}

private record NoTableChange()
implements TableChangeInfo {}
Expand All @@ -4115,7 +4112,7 @@ private record FirstChangeSnapshot(Snapshot snapshot)
private record UnknownTableChange()
implements TableChangeInfo {}

private record CorruptedTableChange()
private record GoneOrCorruptedTableChange()
implements TableChangeInfo {}

private static TableStatistics getIncrementally(
Expand Down
11 changes: 8 additions & 3 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1801,9 +1801,14 @@ private void testMaterializedViewBaseTableGone(boolean initialized)
assertUpdate("REFRESH MATERIALIZED VIEW " + viewName, 1);
}
assertUpdate("DROP TABLE " + baseTable);
assertQueryFails(
"TABLE " + viewName,
"line 1:1: Failed analyzing stored view '%1$s\\.%2$s\\.%3$s': line 3:3: Table '%1$s\\.%2$s\\.%4$s' does not exist".formatted(catalog, schema, viewName, baseTable));
if (initialized) {
assertQuerySucceeds("TABLE " + viewName);
}
else {
assertQueryFails(
"TABLE " + viewName,
"line 1:1: Failed analyzing stored view '%1$s\\.%2$s\\.%3$s': line 3:3: Table '%1$s\\.%2$s\\.%4$s' does not exist".formatted(catalog, schema, viewName, baseTable));
}
assertUpdate("DROP MATERIALIZED VIEW " + viewName);
}

Expand Down