Validate CatalogName is lowercase #27609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
Member
Author
|
CI
|
Currently all objects in Trino are lowercase. However, the catalog store does not validate this. It's possible to create `etc/catalog/TPCH.properties` which will create `TPCH` catalog. The system starts, but the catalog is not usable. The upcoming case-sensitivity changes target, at least in near term, non-lowercase schema, tables and column names. Eventually it may be extended to support non-lowercase catalog names, but that's not a near term goal. However, this work will require removal of lowercasing in `Identifier` and `QualifiedName`. Expecting `CatalogName` to be lowercase may prevent a class of issues while case-sensitivity story evolves.
findepi
force-pushed
the
findepi/names
branch
from
875e91d to
6cfdea3
Compare
wendigo
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all objects in Trino are lowercase. However, the catalog store does not validate this. It's possible to create
etc/catalog/TPCH.propertieswhich will createTPCHcatalog. The system starts, but the catalog is not usable.The upcoming case-sensitivity changes target, at least in near term, non-lowercase schema, tables and column names. Eventually it may be extended to support non-lowercase catalog names, but that's not a near term goal. However, this work will require removal of lowercasing in
IdentifierandQualifiedName(#26339). ExpectingCatalogNameto be lowercase may prevent a class of issues while case-sensitivity story evolves.