You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was work done in OSS Trino by @pettyjamesm to implement a vectorized approach for combined columnar hash calculation generation via codegen(PR: #19302) for FlatGroupByHash operator. This PR extends the work for Partitioned Exchange and Local Exchange Operators.
The results from running BenchmarkPartitionedOutputOperator.verifyAddPage for varying number of columns are summarized below:
Prototype(Codegen based Vectorized HashGenerator)seconds
% Gain
1
3.1
2.6
16.12903
5
5.4
3.8
29.62963
10
8
6.3
21.25
50
40
28
30
100
93
69
25.80645
500
603
343
43.11774
1000
1065
623
41.50235
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
## Section* Fix some things. ({issue}`issuenumber`)
Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.
Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report
Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.
Building Trino finished with status: failure
Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, there was work done in OSS Trino by @pettyjamesm to implement a vectorized approach for combined columnar hash calculation generation via codegen(PR: #19302) for FlatGroupByHash operator. This PR extends the work for Partitioned Exchange and Local Exchange Operators.
The results from running
BenchmarkPartitionedOutputOperator.verifyAddPagefor varying number of columns are summarized below:Environment: MacOS Local Machine
Partition Count: 256
Runtime JDK: Java 25
Page Count: 5000
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: