Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of query system #242

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Rewrite of query system #242

wants to merge 22 commits into from

Conversation

almasaeed2010
Copy link
Contributor

This PR will address issues #241 and #238

@almasaeed2010
Copy link
Contributor Author

We are facing one major issue now that we started indexing in a way that supports faceted-search. In the entities index, the content column must change from text to dynamic with properties. This is obviously a breaking change that requires us to release 3.0 and a migration step.

One solution is to add a new column to index data using the new data mapping type. This also requires users to rerun the indexing process but it won't stop the currently functional search. A big drawback to this is the size of the index. By indexing the same information twice, we would double the size of the index.

@almasaeed2010
Copy link
Contributor Author

almasaeed2010 commented Feb 25, 2019

The simple query string needs to be changed to use an array of bool queries. The reason is that dealing with escaping is hard with faceted search. What we want to eventually get is similar to the following:

{
  "bool": {
    "must": [
      {
          "simple_query_string": {
             "fields": ["content.rdfs__type", "content.obi__organism"],
              "query": "term"
          }
      }
    ]
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant