Remove all networkextension #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per tripflex#116 We need to remove all empty com.apple.developer.networking.networkextension to be able to build for iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #116
We need to remove all empty com.apple.developer.networking.networkextension to be able to build for iOS
Requirements
Description of the Change
I removed all empty com.apple.developer.networking.networkextension to be able to build for iOS
As per #116 this prevented me from builing on iOS
Alternate Designs
We could have added the String inside the PL file, but I am not sure which ones are used
Why Should This Be In Core?
So iOS is able to build
Benefits
People can build iOS Apps
Possible Drawbacks
Maybe we need the empty networkextension?
Applicable Issues