Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api >= 29 Network specifier new method for Android 10 #122

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

klich3
Copy link

@klich3 klich3 commented Feb 18, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Simply added new method for Android 10 with Api >= 29.
Oldes one are depricated, whith this method you can suggest network for connect.

Benefits

Support new versions of devices.

Possible Drawbacks

No have negative impacts.

Correction aported by DarAng3L

Co-authored-by: Mihai <[email protected]>
@FawadNL
Copy link

FawadNL commented Oct 20, 2022

@DarkAng3L can you please review and approve this PR?

@DarkAng3L
Copy link

@DarkAng3L can you please review and approve this PR?

I think a similar change needed to be made on line 2008 also (#122 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants