[18.0][MIG] base_report_to_printer: Migration to 18.0 #2

trisdoan · 2024-10-09T09:29:04Z

Note

Missing commits from 14.0 are ported in [17.0][FW] oca-port: forward missing commits from 14.0 #1
Tests are failed due to lack of CUPS server configured

Changes in 18.0

ir.property was removed in odoo/odoo@de302c2. Hence, replace default value for property_printing_action_id with invoked function.
doall & numbercall fields were removed from ir_cron in odoo/odoo@3a9949a
callable is not validated in selection any longer due to performance cost in odoo/odoo@eaef3d2. So, initialise AVAILABLE_ACTION_TYPES with the precomputed value instead of the function which returns the precomputed value.

This changes

Take this chance to replace percent format with f-string

nguyenminhchien · 2024-10-11T07:58:08Z

base_report_to_printer/models/printing_report_xml_action.py

+        comodel_name="res.users", string="User", required=True, ondelete="cascade"
+    )
+    action = fields.Selection(
+        selection=lambda s: s.env["printing.action"]._available_action_types(),


Error when visiting Settings > Printing > Report

nguyenminhchien · 2024-10-11T08:05:41Z

base_report_to_printer/wizards/printing_printer_update_wizard_view.xml

+    <menuitem
+        action="action_printer_update_wizard"
+        sequence="40"
+        id="menu_printer_update_wizard"


this menu (Update Printers from CUPS) is useless, no group has create right on this wizard, even Admin user will face this error:

Hi anh, I fixed and included in #1

nguyenminhchien · 2024-10-11T08:25:39Z

base_report_to_printer/views/ir_actions_report.xml

+                    <group>
+                        <field name="property_printing_action_id" />
+                        <field name="printing_printer_id" />
+                        <field name="printer_tray_id" />


Error when accessing to menu Settings > Technica > .. > Reports

nguyenminhchien · 2024-10-11T08:43:03Z

base_report_to_printer/tests/test_report.py

+                }
+            )
+        )
+        self.report_text = self.Model.create(


self.report_text = self.Model.create() is duplicated after porting
Seems that you don't need to port fc3ad72 but add it to blacklist

anw, pick the commit a7f1f36 into this PR as well.

Hi anh, fc3ad72 was wrongly ported, I fixed and updated the PR

Migrate ir_report.py to new API Migrate printing.py to new API Migrate res_users.py to new API Migrate report_xml_action.py to new API Migrate wizard/update_printers.py to new API Better view for wizard Recursion when calling a method with old-style api signature from browse Remove the Lock because it is useless on multiprocess Replace it by a database lock so the different processes are all aware of the lock and the last update timestamp. browse is called often enough to call the update routine (even too much) Implements the print on the new 'report' model Restore the print capability on deprecated reports Update copyrights Improve form view, add search view for printers Update translations, add a string to URI so it is uppercased missing api decorator We need the report in print_document and print options (needed in printer_tray) Move the 'skip_update' right in the browse, it prevents a loop See odoo/odoo#3644 Also, it helps to have the value set/read in context close to each other. Avoid to hits the database too many times to check if the list of printers needs to be refreshed. Keep the last update datetime in cache and invalidate this datetime if is is older than POLL_INTERVAL. Thus, one process won't hit the DB more than 1 time every POLL_INTERVAL (10 seconds currently) to check if it needs to update the list. Refresh the list of printers every 15 seconds instead of 10 Extract a method so it will be easier to override in printer_tray Error on installation of the module Invalidate the cache when the table is created so the table_exists() method returns a fresh value after creation of the table Use a cron instead of threads to update printers status The implementation with threads was blocking the loading of the server in multiprocess. Using a cron will lower the frequency of the updates but at least it is simple and reliable. Fixes OCA#14 Do not write the printer status if it has not changed Avoid unnecessary UPDATE every minute Clean the XML file (remove eval, reindent) Give access to models to all users for reading So they are able to print

[Usability] Auto-add Administrator user to the Print group Make XML code more readable base_report_to_printer: add support for remote CUPS server (not just localhost) More logging and better error handling Add CUPS_HOST in more debug logs

Instead, a notification is displayed to the user. When report.get_pdf() is called on a report that must be printer, it will print the report *and* returns the pdf, thus code that calls directly report.get_pdf() will print the pdf on the printer as expected. Fixes OCA#16

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

By calling `super.get_pdf` in print_document we can encounter trouble with MRO resolution that prevent custom report parser (e.g. override of `get_pdf`) to be called. The fix consist of not calling `super` and prevent multiple call to 'printer.print_document'

* context was lost while getting report * now it will be passed using with_context * could be used for print_options (example: pass copies amount for productlabals)

cups is an external dependency, if it is not installed Odoo will not start. OCA guidelines specify guidelines for External dependencies, code is from there.

* Set api.multi for action called as `object` on view * Merge syleam printers module into base_report_to_printer (OCA#60) * [IMP] Updated unit tests * [FIX] Fixed renamed attributes * [FIX] Remove deleted fields * [IMP] Add printing.server and printing.job models * [IMP] Allow to cancel all jobs, enable, and disable printers * [IMP] Split the cups part of print_document into a new print_file method * [IMP] Updated cron job to run the action_update_jobs method * [ADD] Add a migration script to create a printing server from configuration * [MIG] Migrate base_report_to_printer to v10.0 Removed deprecated methods on printing.printer (replaced by methods on printing.server) * [IMP] Add wkhtmltopdf in travis configuration file * [FIX] base_report_to_printer: Fix Update Job Cron * Fix API issue with Update Job Cron ** Forward Port from 9.0 * [FIX] Fixed the res.users view The string attribute should not be used as a selector, because it is translatable. * [FIX] Fixed the print_document method of report The new API migration was made to @api.multi because of the "cr, uid, ids" signature, but "ids" was the ids of the records to print here, not the report's ids. Also, the new API version of "get_pdf" get directly the ids of the records to print in the standard module, not a recordset. * [FIX] UI is now (un)blocked only when using qweb-pdf reports in standard addons

* FIX format parameter To be able to print files in raw format it's needed to set this parameter. Previous code was not able to print raw files, but it didn't get error because 'format' used on line 107 is assumed as a format funtion, because format parameter was not on this scope. * FIX pep8

Provided steps to installing PyCups

Printer Tray isn't an app Base Report To printer ir.actions.report.xml view xpath error and missing page name Put to before security as security tab doesn't do much and if this module is installed it should be the hero page

Currently translated at 76.2% (125 of 164 strings) Translation: report-print-send-16.0/report-print-send-16.0-base_report_to_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-base_report_to_printer/it/

Currently translated at 100.0% (164 of 164 strings) Translation: report-print-send-16.0/report-print-send-16.0-base_report_to_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-base_report_to_printer/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: report-print-send-17.0/report-print-send-17.0-base_report_to_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-17-0/report-print-send-17-0-base_report_to_printer/

Currently translated at 100.0% (160 of 160 strings) Translation: report-print-send-17.0/report-print-send-17.0-base_report_to_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-17-0/report-print-send-17-0-base_report_to_printer/it/

Currently translated at 100.0% (160 of 160 strings) Translation: report-print-send-17.0/report-print-send-17.0-base_report_to_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-17-0/report-print-send-17-0-base_report_to_printer/sv/

Currently translated at 100.0% (160 of 160 strings) Translation: report-print-send-17.0/report-print-send-17.0-base_report_to_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-17-0/report-print-send-17-0-base_report_to_printer/zh_CN/

nguyenminhchien

Should squash these commits into a single one: [MIG] base_report_to_printer: Migration to 18.0

[MIG] base_report_to_printer: Migration to 18.0

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch 5 times, most recently from 6e0b8f0 to ea2958c Compare October 11, 2024 02:31

nguyenminhchien suggested changes Oct 11, 2024

View reviewed changes

nguyenminhchien reviewed Oct 11, 2024

View reviewed changes

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from ea2958c to 97c6d10 Compare October 14, 2024 04:07

guewen and others added 22 commits October 14, 2024 11:09

Add OCA as author of OCA addons

c968343

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

The alteration of the context has no effect

67f50b5

Improve bloated condition test

7ffdfbf

[FIX] base_report_to_printer: make get_pdf callable from 8.0 api

213f495

[FIX] test if the module is installed before monkey patching

6066cdf

[PEP8]

2976381

[UPD] prefix versions with 8.0

258e66b

pass context to printer to use it for example in print_options()

a01302f

* context was lost while getting report * now it will be passed using with_context * could be used for print_options (example: pass copies amount for productlabals)

Add support for multiple copies

670b7ea

[IMP] Soft fail on missing cups import

66b0b57

cups is an external dependency, if it is not installed Odoo will not start. OCA guidelines specify guidelines for External dependencies, code is from there.

[MIG] base_report_to_printer: Upgrade to v9

96fe127

Fix placeholder for repo in readme.rst

f506255

[MIG] Rename manifest files

eb330cd

Update README.rst

dad62eb

Provided steps to installing PyCups

[FIX] base_report_to_printer: A button method should be @api.multi

d569a89

[FIX] Minor bugfixes

7e16f3f

Printer Tray isn't an app Base Report To printer ir.actions.report.xml view xpath error and missing page name Put to before security as security tab doesn't do much and if this module is installed it should be the hero page

OCA-git-bot and others added 18 commits October 14, 2024 11:10

[BOT] post-merge updates

e021d4b

[IMP] base_report_to_printer: pre-commit auto fixes

25a50cf

[MIG] base_report_to_printer: Migration to 17.0

f0c17f3

[UPD] Update base_report_to_printer.pot

98a4861

[BOT] post-merge updates

b7019ac

[FIX] line too long

78d17b9

[BOT] post-merge updates

55cdfc0

[14.0][FIX] base_report_to_printer: Don't use safe_eval as module

c8c5bfd

Add Module base_report_to_label_printer

d6510c1

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from 97c6d10 to d375fd1 Compare October 14, 2024 04:11

oca-port: blacklist PR(s) 242 for base_report_to_printer

0078dce

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from d375fd1 to dd3fdff Compare October 14, 2024 04:16

nguyenminhchien suggested changes Oct 14, 2024

View reviewed changes

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from dd3fdff to 67ebf77 Compare October 14, 2024 08:40

trisdoan added 3 commits October 14, 2024 15:56

[FIX] base_report_to_printer: access error and wrong translated terms

c04e21b

[IMP] base_report_to_printer: pre-commit execution

0ed4ffc

[MIG] base_report_to_printer: Migration to 18.0

a5aae19

[MIG] base_report_to_printer: Migration to 18.0

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from 67ebf77 to a5aae19 Compare October 14, 2024 08:57

trisdoan requested a review from nguyenminhchien October 14, 2024 08:58

nguyenminhchien approved these changes Oct 14, 2024

View reviewed changes

trisdoan closed this Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] base_report_to_printer: Migration to 18.0 #2

[18.0][MIG] base_report_to_printer: Migration to 18.0 #2

trisdoan commented Oct 9, 2024 •

edited

Loading

nguyenminhchien Oct 11, 2024

nguyenminhchien Oct 11, 2024

trisdoan Oct 14, 2024

nguyenminhchien Oct 11, 2024

nguyenminhchien Oct 11, 2024

trisdoan Oct 14, 2024

nguyenminhchien left a comment

[18.0][MIG] base_report_to_printer: Migration to 18.0 #2

[18.0][MIG] base_report_to_printer: Migration to 18.0 #2

Conversation

trisdoan commented Oct 9, 2024 • edited Loading

Note

Changes in 18.0

This changes

nguyenminhchien Oct 11, 2024

Choose a reason for hiding this comment

nguyenminhchien Oct 11, 2024

Choose a reason for hiding this comment

trisdoan Oct 14, 2024

Choose a reason for hiding this comment

nguyenminhchien Oct 11, 2024

Choose a reason for hiding this comment

nguyenminhchien Oct 11, 2024

Choose a reason for hiding this comment

trisdoan Oct 14, 2024

Choose a reason for hiding this comment

nguyenminhchien left a comment

Choose a reason for hiding this comment

trisdoan commented Oct 9, 2024 •

edited

Loading