Fix isString() method in yaml_cpp_adapter #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tristanpenman, @psigen,
First of all, thanks for the amazing work in this library, super cool!
I've tried the
yaml_cpp_adapter
to validate a YAML file with a custom JSON schema and experience runtime errors when the YAML app included arrays of objects, for exampleand I seem to have found the bug that was causing these runtime errors. While it's true that each element in a YAML should be considered as string (hence probably the
return true
in theisString()
method), this should only return true when the element is actually a scalar value and not a sequence or a map.Happy to hear your feedback.