Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequence batcher padding string correlation ids to maximum size #339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix sequence batcher padding string correlation ids to maximum size #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf6be69
Sequence batcher no longer pads string corrids
CGranger-sorenson Mar 27, 2024
5bcd734
Merge branch 'main' into main
nnshah1 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sequence_batch_scheduler/sequence_batch_scheduler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,7 +1345,9 @@ SequenceBatch::SetControlTensors(
if (seq_corr_id->DType() == inference::DataType::TYPE_STRING) {
// 4 bytes for length of string plus pre-defined max string correlation id
// length in bytes
size_p = 4 + triton::core::STRING_CORRELATION_ID_MAX_LENGTH_BYTES;
std::string correlation_id = corrid.StringValue();
uint32_t correlation_id_length = correlation_id.length();
size_p = 4 + correlation_id_length;
}

TRITONSERVER_MemoryType memory_type;
Expand Down
Loading