Changes to fix data types mismatches for armv7 build #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
22 tasks
| @@ -255,7 +255,7 @@ CacheEntry::SerializeResponseOutput( | |||
| // Pack everything into provided buffer | |||
| uint64_t position = 0; | |||
There was a problem hiding this comment.
out of curiosity, why this line doesn't cause issues
There was a problem hiding this comment.
@oandreeva-nv you have a good point. I'll elaborate a bit more on this one. The real issue is with the following lines. SerializeResponseOutput is expecting a size_t pointer:
CacheEntry::SerializeResponseOutput( const InferenceResponse::Output& output, Byte* buffer, size_t* output_size)
For our platform there is a mismatch between these two types:
error: cannot convert ‘uint64_t*’ {aka ‘long long unsigned int*’} to ‘size_t*’ {aka ‘unsigned int*’}
| @@ -255,7 +255,7 @@ CacheEntry::SerializeResponseOutput( | |||
| // Pack everything into provided buffer | |||
| uint64_t position = 0; | |||
| // Total serialized output size | |||
| memcpy(buffer + position, &total_byte_size, sizeof(uint64_t)); | |||
| memcpy(buffer + position, &total_byte_size, sizeof(size_t)); | |||
| position += sizeof(uint64_t); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running the server and core in a armv7 device.
Build for platform linux/arm/v7 failed because the code was using 64 bit size variables and we have 32 bit.