Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gpg keys; cmake installation streamlined #4307

Closed
wants to merge 2 commits into from

Conversation

borisfom
Copy link
Contributor

  1. Fixed container build failure : Updated GPG keys according to:
    GPG signing key rotation for CUDA repositories NVIDIA/cuda-repo-management#4

  2. Changed cmake install to pip-based one. In some base containers (notably upcoming CUDA 11.8), existing wget install was successful, but old cmake still in the path. Install via pip is simpler and works everywhere.

Signed-off-by: Boris Fomitchev [email protected]

@deadeyegoodwin
Copy link
Contributor

Note this slack thread: https://nvidia.slack.com/archives/C8H1F7HAM/p1651252005561269
There are some changes going on with how cmake is installed in the base image. Using pip to install cmake instead of apt is at best a strange thing to do. Why does our current way of installing cmake with apt need to change just because using cuda 11.8? Why would using CUDA 11.8 have anything to do with how cmake is installed or used?

@rmccorm4
Copy link
Collaborator

@borisfom any updates based on David's feedback above?

@rmccorm4
Copy link
Collaborator

Closing due to lack of activity and the key-rotation issues have been fixed. New CUDA version related issues have likely been fixed by this point as well if there were any.

@rmccorm4 rmccorm4 closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants