docs: Simplify PR templates #7753

yinggeh · 2024-10-29T19:49:51Z

What does the PR do?

Internal: remove CI Pipeline ID and commit type sections. Optional GitHub issue.
External: remove commit type section.

Checklist

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

docs

Related PRs:

Where should the reviewer start?

Test plan:

CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

closes GitHub issue: #xxx

* Mlflow plugin fix

* Unify iGPU test build with x86 ARM * adding TRITON_IGPU_BUILD to core build definition; adding logic to skip caffe2plan test if TRITON_IGPU_BUILD=1 * re-organizing some copies in Dockerfile.QA to fix igpu devel build * Pre-commit fix --------- Co-authored-by: kyle <[email protected]>

* adding default value for TRITON_IGPU_BUILD=OFF * fix newline --------- Co-authored-by: kyle <[email protected]>

* Add test case for decoupled model raising exception * Remove unused import * Address comment

* vLLM Benchmarking Test

#6639) * Add ability to configure GRPC max connection age and max connection age grace * Allow pass GRPC connection age args when they are set from command ---------- Co-authored-by: Katherine Yang <[email protected]>

…d test (#6713) * Modify HTTP frontend to return error code reflecting Triton error * Add test for dedicated HTTP error. Releax existing test on HTTP code * Address comment. Fix copy right

* Update README and versions for 23.12 branch * Bring back the README (#6671) * Bring back the README * main -> r23.12 * Remove L0_libtorch_nvfuser (#6674) * iGPU build refactor (#6684) * Fix iGPU CMakeFile tags (#6695) (#6698) * Unify iGPU test build with x86 ARM * adding TRITON_IGPU_BUILD to core build definition; adding logic to skip caffe2plan test if TRITON_IGPU_BUILD=1 * re-organizing some copies in Dockerfile.QA to fix igpu devel build * Pre-commit fix --------- Co-authored-by: kyle <[email protected]> * Update windows Dockerfile versions (#6672) Changing version to the latest one Co-authored-by: Misha Chornyi <[email protected]> * Remove README banner (#6719) * Update README --------- Co-authored-by: tanmayv25 <[email protected]> Co-authored-by: Jacky <[email protected]> Co-authored-by: kyle <[email protected]>

* testing apprroach with pre-built image * Build TensorRT-LLM * Disable Triton Build * Remove file * Update config * Changet PATH variables * Update path * Update configuration for CMake * Getting back TRITON_BUILD flag * REvert missing files creation * Update configuration for the PyTorch installation * Update configuration for docker * Change the location * Update configuration * update config * Set CMake version to 3.27.7 * Fix double slash typo * remove unused strings * restore typo (#6680) * remove old line * fix line indentation * Update LD_LIBRARY_PATH for TensorRT-LLM * Addign TRT llm changes * remove TRT-LLM container from bhte argument list * Update indentation

* Update RE2 package location * Use only 1 parallel thread for build * Revert "Use only 1 parallel thread for build" This reverts commit 93eab3a.

* Add testing for zero tensors in PyTorch backend * Fix up * Review edit

* Do not fail test on insufficient hardware concurrency * Track instead of fail test if cannot replicate load while async unload * Add some TODOs for the sub-test

* Simplify cmake install command * Fix up * Review comment

* Add cmdline option to set model load retry. Add test * Fix copyright * Minor change on testing model * Remove unused import

- Extend L0_storage_S3 test timeout

#6775)

* Patch L0_model_config with runtime * Add L0_pytorch_python_runtime * Update expected runtime field * Add test for escaping runtime * Add comments on unit test imports * Add invalid runtime test * User to build PyTorch env * Update copyright

* Test case * Update metrics.md * Fix alert * Add copyright * Update test * Improve pinned_memory_metrics_test.py * Update qa/L0_metrics/pinned_memory_metrics_test.py Co-authored-by: Ryan McCormick <[email protected]> * Update pinned_memory_metrics_test.py --------- Co-authored-by: Ryan McCormick <[email protected]>

Added support for OTel context propagation --------- Co-authored-by: Markus Hennerbichler <[email protected]> Co-authored-by: Ryan McCormick <[email protected]>

This validates the change made to ../core wrt how model configuration mtime is handled.

… outputs are not created (#7701)

Co-authored-by: Ryan McCormick <[email protected]>

…-commi… (#7699)

…ent startup timeouts (#7730)

)

…er each model reload (#7735)

jbkyang-nvi · 2024-10-29T20:47:02Z

.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md

 - [ ] Added [test plan](#test-plan) and verified test passes.
 - [ ] Verified that the PR passes existing CI.
 - [ ] Verified copyright is correct on all changed files.
 - [ ] Added _succinct_ git squash message before merging [ref](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
 - [ ] All template sections are filled out.
+- [ ] Optional: Related issues are referenced.


I don't think this should be optional. It's useful for cherry picks to know of related PRs, and if the PR closes an issue, we should mark it as closed

It's optional because most PRs do not related to a GitHub issue.

when I created this PR, I conflated the word "issue". I agree that only sometimes the PR is related to a Github issue. Can you add a checkbox that says:

Suggested change

- [ ] Optional: Related issues are referenced.

- [ ] Linked related PRs, if any.

- [ ] Optional: Related issues are referenced.

There is already a "Related PRs" section.

I think "related issue" should be a dedicated section, GitHub should be able to link and close the issue automatically if the specified format is followed: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

jbkyang-nvi · 2024-10-29T20:48:46Z

.github/PULL_REQUEST_TEMPLATE/pull_request_template_external_contrib.md

+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+-->
+


will updating copyright here produce a big blob of text in the PR template? If yes, I suggest we remove it

Not sure if we can merge without passing all pre-commit checks. cc @rmccorm4

I would argue this piece of code specifically, does not need a copyright. If you are concerned with the pre-commit check for copyright being not accurate, please link the copyright checking script: https://github.com/triton-inference-server/server/blob/main/qa/common/check_copyright.py. You can see that the Pull Request document is excluded from the check as well as general .md files

It's the recent PR that added add_copyright.py to the pre-commit hook.
We might want to skip some files and paths like we do in check_copyright.py.
See #7666

GuanLuo · 2024-10-29T21:16:48Z

.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md

 #### What does the PR do?
 <!-- Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.-->

 #### Checklist
- [ ] PR title reflects the change and is of format `<commit_type>: <Title>`
+- [ ] PR title reflects the change and is of format `<commit_type>: <Title>`. Check the [conventional commit type](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type).


I would want to have a list of commonly used types ("i.e. feat, fix, doc") and mention that the link points to more types.

mc-nv and others added 30 commits December 11, 2023 01:54

restore typo (#6680)

c329f48

Update 'main' to track development of 2.42.0 / 24.01 (#6673)

d496f95

iGPU build refactor (#6684) (#6691)

d191ef9

Mlflow Plugin Fix (#6685)

0b63e0d

* Mlflow plugin fix

Fix extra content-type headers in HTTP server (#6678)

ebd6a3e

adding default value for TRITON_IGPU_BUILD=OFF (#6705)

57b49b4

* adding default value for TRITON_IGPU_BUILD=OFF * fix newline --------- Co-authored-by: kyle <[email protected]>

Add test case for decoupled model raising exception (#6686)

b0bbabb

* Add test case for decoupled model raising exception * Remove unused import * Address comment

Escape special characters in general docs (#6697)

8f5f515

vLLM Benchmarking Test (#6631)

5b46d0e

* vLLM Benchmarking Test

Modify HTTP frontend to return error code reflecting Triton error. Ad…

a4b8162

…d test (#6713) * Modify HTTP frontend to return error code reflecting Triton error * Add test for dedicated HTTP error. Releax existing test on HTTP code * Address comment. Fix copy right

Remove double unit test (#6714)

cb0c2e5

Update RE2 package location (#6750)

14f70b6

* Update RE2 package location * Use only 1 parallel thread for build * Revert "Use only 1 parallel thread for build" This reverts commit 93eab3a.

Add testing for zero tensors in PyTorch backend (#6760)

6bc5625

* Add testing for zero tensors in PyTorch backend * Fix up * Review edit

Fix L0_lifecycle on insufficient hardware concurrency (#6762)

fb3747a

* Do not fail test on insufficient hardware concurrency * Track instead of fail test if cannot replicate load while async unload * Add some TODOs for the sub-test

Simplify cmake install command (#6725)

1ea633a

* Simplify cmake install command * Fix up * Review comment

Add cmdline option to set model load retry. Add test (#6764)

b48aa57

* Add cmdline option to set model load retry. Add test * Fix copyright * Minor change on testing model * Remove unused import

Increase timeout (#6774)

8af13e9

- Extend L0_storage_S3 test timeout

Move from jfrog artifactory to archives.boost.io to fix boost download (

b5f1f7d

#6775)

Add Triton Inference Server In-Process Python API Tests

310c38c

Bump min cxx standard to 17 (#6742)

2782d30

Update 'main' to track development of 2.42.0 / 24.02 (#6786)

c205451

Support for Context Propagation for OTel trace mode (#6785)

4a719e4

Added support for OTel context propagation --------- Co-authored-by: Markus Hennerbichler <[email protected]> Co-authored-by: Ryan McCormick <[email protected]>

Use current time when overwriting model configuration. (#6727)

87165b2

This validates the change made to ../core wrt how model configuration mtime is handled.

Added docs for otel context propagation (#6804)

7b06a37

kthui and others added 17 commits October 16, 2024 09:41

test: Allow ensemble to create the final response even if some of the…

0200d2c

… outputs are not created (#7701)

test: Update server repo for some tests (#7704)

1a54d83

docs: Add example outputs to OpenAI Frontend docs (#7691)

2961cf8

Co-authored-by: Ryan McCormick <[email protected]>

chore: Fix genai-perf command and add missing copyrights (#7710)

01e77a8

docs: Clarify meanings of ensemble key and value (#7711)

aeb20a1

fix: Re-enables copyright hook, updates GitHub Action to only run pre…

dedb9e7

…-commi… (#7699)

fix: Fix L0_perf_nomodel shared memory (#7709)

940aa22

Change compute capablity min value (#7708)

6f6cbe0

build: tritonfrontend support for no/partial endpoint builds (#7605)

aa93b95

Revert "Change compute capablity min value (#7708)" (#7721)

ee198de

test: Test and document histogram latency metrics (#7694)

12b1968

fix: Copy models out of NFS before starting Triton to avoid intermitt…

10d7eaa

…ent startup timeouts (#7730)

docs: Add support matrix for model parallelism in OpenAI Frontend (#7715

2f8de73

)

test: Add L0_additional_dependency_dirs (#7707)

dcfc6a0

test: Add small delay to L0_lifecycle test_load_new_model_version aft…

128f19a

…er each model reload (#7735)

Update pull_request_template_internal_contrib.md

678fabd

Update pull_request_template_external_contrib.md

9695d15

yinggeh added the PR: docs Documentation only changes label Oct 29, 2024

yinggeh self-assigned this Oct 29, 2024

yinggeh and others added 3 commits October 29, 2024 12:51

Update pull_request_template_internal_contrib.md

e3f7eac

Add copyright

a4b7f29

Update pull_request_template_external_contrib.md

3e75a93

yinggeh requested review from jbkyang-nvi and rmccorm4 October 29, 2024 20:03

yinggeh changed the title ~~docs: Update pull_request_template_internal_contrib.md~~ docs: Simplify PR templates Oct 29, 2024

jbkyang-nvi reviewed Oct 29, 2024

View reviewed changes

GuanLuo reviewed Oct 29, 2024

View reviewed changes

remove copyrights

dd41b92

pvijayakrish force-pushed the yinggeh-update-pr-template branch from db56608 to dd41b92 Compare January 15, 2025 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Simplify PR templates #7753

docs: Simplify PR templates #7753

yinggeh commented Oct 29, 2024 •

edited

Loading

jbkyang-nvi Oct 29, 2024

yinggeh Oct 29, 2024

jbkyang-nvi Oct 29, 2024 •

edited

Loading

yinggeh Oct 30, 2024

GuanLuo Oct 30, 2024

jbkyang-nvi Oct 29, 2024

yinggeh Oct 29, 2024 •

edited

Loading

jbkyang-nvi Oct 29, 2024 •

edited

Loading

yinggeh Oct 30, 2024 •

edited

Loading

GuanLuo Oct 29, 2024

	- [ ] Optional: Related issues are referenced.
	- [ ] Linked related PRs, if any.
	- [ ] Optional: Related issues are referenced.

docs: Simplify PR templates #7753

Are you sure you want to change the base?

docs: Simplify PR templates #7753

Conversation

yinggeh commented Oct 29, 2024 • edited Loading

What does the PR do?

Checklist

Commit Type:

Related PRs:

Where should the reviewer start?

Test plan:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

jbkyang-nvi Oct 29, 2024

Choose a reason for hiding this comment

yinggeh Oct 29, 2024

Choose a reason for hiding this comment

jbkyang-nvi Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

yinggeh Oct 30, 2024

Choose a reason for hiding this comment

GuanLuo Oct 30, 2024

Choose a reason for hiding this comment

jbkyang-nvi Oct 29, 2024

Choose a reason for hiding this comment

yinggeh Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

jbkyang-nvi Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

yinggeh Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

GuanLuo Oct 29, 2024

Choose a reason for hiding this comment

yinggeh commented Oct 29, 2024 •

edited

Loading

jbkyang-nvi Oct 29, 2024 •

edited

Loading

yinggeh Oct 29, 2024 •

edited

Loading

jbkyang-nvi Oct 29, 2024 •

edited

Loading

yinggeh Oct 30, 2024 •

edited

Loading