Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some of the errors I've encountered while following tutorials #26

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix some of the errors I've encountered while following tutorials #26

wants to merge 3 commits into from

Conversation

adamwawrzynski
Copy link

While doing the tutorial exercises, I had to fix some bugs to make the examples work. This PR contains the fixes I added to the code.

@AmberLJC
Copy link

AmberLJC commented Jun 9, 2023 •
edited
Loading

Someone should help merge this pr, I encounter almost the same problem for hugging face example

@twskj twskj mentioned this pull request Jul 25, 2023
Closed
@dyastremsky
Copy link
Contributor

CC: @tanayvarshney @nealvaidya

@dyastremsky
Copy link
Contributor

Thank you for making these fixes! Have you submitted a Contributor License Agreement so that we can review these changes? https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

CC: @nealvaidya @tanayvarshney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwawrzynski @AmberLJC @dyastremsky