Llama tutorial for TRTLLM #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbkyang-nvi
force-pushed
the
kyang-add-llama-tutorials
branch
from
cd530f5
to
f21a8e9
Compare
jbkyang-nvi
changed the title
krishung5
reviewed
Oct 26, 2023
fpetrini15
reviewed
Oct 26, 2023
fpetrini15
reviewed
Oct 26, 2023
jbkyang-nvi
requested review from
matthewkotila,
nnshah1,
fpetrini15,
rmccorm4 and
krishung5
nnshah1
reviewed
Oct 27, 2023
fpetrini15
reviewed
Oct 27, 2023
nnshah1
previously approved these changes
Oct 27, 2023
jbkyang-nvi
force-pushed
the
kyang-add-llama-tutorials
branch
from
f7fdfc4
to
fb30384
Compare
nnshah1
reviewed
Oct 27, 2023
fpetrini15
reviewed
Oct 27, 2023
| > located in the same llama examples folder. | ||
| > | ||
| > ```bash | ||
| > python3 /run.py --engine_dir=<path to your engine>/1-gpu/ --max_output_len 100 --tokenizer_dir <path to your llama repo>/Llama-2-7b-hf --input_text "How do I count to ten in French?" |
There was a problem hiding this comment.
Suggested change
| > python3 /run.py --engine_dir=<path to your engine>/1-gpu/ --max_output_len 100 --tokenizer_dir <path to your llama repo>/Llama-2-7b-hf --input_text "How do I count to ten in French?" | |
| > python3 run.py --engine_dir=<path to your engine>/1-gpu/ --max_output_len 100 --tokenizer_dir <path to your llama repo>/Llama-2-7b-hf --input_text "How do I count to ten in French?" |
fpetrini15
reviewed
Oct 27, 2023
| ```bash | ||
| tritonserver --model-repository=/opt/tritonserver/inflight_batcher_llm | ||
| ``` | ||
| Note if you built the engine with `--world-size X` where `X` is greater than 1, you will need to use the [launch_triton_server.py](https://github.com/triton-inference-server/tensorrtllm_backend/blob/release/0.5.0/scripts/launch_triton_server.py) script. |
There was a problem hiding this comment.
Suggested change
| Note if you built the engine with `--world-size X` where `X` is greater than 1, you will need to use the [launch_triton_server.py](https://github.com/triton-inference-server/tensorrtllm_backend/blob/release/0.5.0/scripts/launch_triton_server.py) script. | |
| Note if you built the engine with `--world_size X` where `X` is greater than 1, you will need to use the [launch_triton_server.py](https://github.com/triton-inference-server/tensorrtllm_backend/blob/release/0.5.0/scripts/launch_triton_server.py) script. |
|
Beyond the small nits, LGTM! Great work! |
|
nnshah1
previously approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.