Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable Diffusion 1.5 and Stable Diffusion XL Tutorials #82

Merged
merged 86 commits into from
Mar 2, 2024
Merged

Stable Diffusion 1.5 and Stable Diffusion XL Tutorials #82

merged 86 commits into from
Mar 2, 2024

Conversation

nnshah1
Copy link
Contributor

@nnshah1 nnshah1 commented Feb 29, 2024 •
edited
Loading

This update includes two parts:

  1. New Popular Models Tutorial for Stable Diffusion
  2. Updated RayServe deployment example based on Stable Diffusion v1.5

Would like to cherry pick this into 24.02 branch. and once 24.02 is released, test and update based on 24.02 base containers.

nnshah1 and others added 22 commits February 26, 2024 07:56
@nnshah1
initial stable diffusion - work in progress
deefc37
@nnshah1
updating with batching enabled
d907813
@nnshah1
update client, model
92b49ea
@nnshah1
updated to create a backend
2140339
@nnshah1
updated for xl and 1.5 seperated configs
141010c
@nnshah1
updated with version info
887f086
updating to read steps from file and prevent parallel engine build
3619b76
remove multi gpu instance capability - not supported
968a0f8
@nnshah1
adding client and base deployment
41db857
update docker ignore for onnx directories
ee0125b
update with arg to build models
2dd3cbd
@nnshah1
updating with basic client
1bea74e
@nnshah1
updated with logging and dynamic batching settings
b4096e6
@nnshah1
updates for making file saving optional and testing client
a73e57e
@nnshah1
Adding documentation
f289784
@nnshah1
updated
4a38b6c
@nnshah1
updates
66e5e2d
@nnshah1
updates
16abc4b
@nnshah1
updates
2588c78
@nnshah1
update relative link
e60a920
@nnshah1
updates
556bd9f
@nnshah1
updated
e898c7b
rmccorm4
rmccorm4 reviewed Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only minor comments. (disclaimer: I did not run through it to test/reproduce like @fpetrini15 🤓 )

rmccorm4
rmccorm4 previously approved these changes Mar 2, 2024
View reviewed changes
@fpetrini15 fpetrini15 self-requested a review March 2, 2024 03:30
fpetrini15
fpetrini15 approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Networking issues are preventing me from stepping through the tutorial ATM, so I'll test it before Monday just in case.

Content looks good to me! Very cool tutorial! 🚀

@nnshah1 nnshah1 merged commit 7849294 into main Mar 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbkyang-nvi jbkyang-nvi jbkyang-nvi left review comments

@fpetrini15 fpetrini15 fpetrini15 approved these changes

@rmccorm4 rmccorm4 rmccorm4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnshah1 @fpetrini15 @rmccorm4 @jbkyang-nvi