Fix parallel build issues #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following line causes strlcat.o and strlcpy.o generate twice: libcompat_la_SOURCES = ../lib/strlcpy.c ../lib/strlcat.c Which causes parallel build issues like: https://bugs.gentoo.org/701894 The log shows that they have been generated twice, but should only be once, the extra one is for libstrlcat.lo, this patch fixes the problem, now the log only shows once for each of them. And also restore the parallel build. Signed-off-by: Robert Yang <[email protected]>
robertlinux
referenced
this pull request
Dec 31, 2019
Independently of each other both the Gentoo project and Westermo found
an issue with massively parallel builds on monster-core-machines. At
Westermo there are 40 core Xeon monsters that stumble when building
sysklogd.
The Gentoo bug report is here:
https://bugs.gentoo.org/701894
The problem stems from strlcat.c and strlcpy.c being used for both
the libcompat convenience library built for libsyslog and als for
syslogd when the system does not have either of the APIs in libc,
i.e. most Linux systems with GLIBC or musl libc.
I can either rewrite the Makefile.am files to handle dependencies
better, or we just disable parallel build like this patch. There's
too few source files to gain anything from parallel build anyway.
Signed-off-by: Joachim Nilsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line causes strlcat.o and strlcpy.o generate twice:
libcompat_la_SOURCES = ../lib/strlcpy.c ../lib/strlcat.c
Which causes parallel build issues like:
https://bugs.gentoo.org/701894
The log shows that they have been generated twice, but should only be once, the
extra one is for libstrlcat.lo, this patch fixes the problem, now the log only
shows once for each of them.
And also restore the parallel build.
Signed-off-by: Robert Yang [email protected]