Keep mode#47
Closed
sdaoden wants to merge 8 commits intotroglobit:masterfrom
sdaoden:keep_mode
Closed
Conversation
Owner
|
LGTM, but will have to wait for the other two PRs it builds on. |
Contributor
Author
|
At your service. |
troglobit
added a commit
that referenced
this pull request
Mar 14, 2022
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Owner
|
Rebased and merged manually to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
It happens that syslogd.c looses the file mode when rotating files, it always uses 0644.
(Your logger.c does not, but CRUX-Linux does not use the logger from sysklogd, it .. uses that from the util-linux package.)
So here is a patch on top of the rotate branch that simply passes the fetched stat mode to carry the mode along.