fix(testcase): remove peer from PeerManager after testcase #6486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
317787106
changed the title
xxo1shine
approved these changes
Nov 26, 2025
| public void clearPeers() { | ||
| for (PeerConnection p : PeerManager.getPeers()) { | ||
| PeerManager.remove(p.getChannel()); | ||
| } |
Contributor
There was a problem hiding this comment.
add Args.clearParam(); ?
Contributor
Author
There was a problem hiding this comment.
This testcase has extended BaseTest which implements Args.clearParam() in @afterclass method.
Federico2014
approved these changes
Nov 27, 2025
warku123
reviewed
Nov 27, 2025
| return; | ||
| } | ||
|
|
||
| logger.info("Receive keep alive message from {}", sender); |
There was a problem hiding this comment.
Maybe it should be sender.getHostString() to keep consistency with lines 121 and 126？
Contributor
Author
There was a problem hiding this comment.
Actually, it's more accurate to logging InetSocketAddress, the style is /IP:port. Line 126 only needs IP
warku123
approved these changes
Nov 27, 2025
halibobo1205
approved these changes
Nov 27, 2025
lvs0075
approved these changes
Nov 27, 2025
kuny0707
approved these changes
Nov 27, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
BackupManagerto help for debugtronNetDelegateis null in PeerStatusCheck to fix NullPointerException when use mock in several testcases, such as org.tron.core.net.peer.PeerStatusCheckMockTest. NullPointerException occurs only in mock test.Why are these changes required?
This PR has been tested by:
Follow up
Extra details