Add support for Service and properly handle timeouts #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To the maintainers of the package: Is there a reason you aren't accepting this? Have you decided to stop maintaining it? We'd really like to be able to use npm packages again instead of referencing this branch through git; if you're not maintaining it, would you be open to passing it to someone who will? |
|
Hey @taxilian, there is no particular reason, we just haven't given it a proper review yet. |
fix spread error response
…ests. Update packages and dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing version if you pass an option for a timeout
{timeout: 1000}and the timeout lapses the resulting promise is never rejected nor resolved. I added a handler for thetimeoutevent to resolve this issue and reject the promise.Additionally I added support for restler's Service as it was useful to me. The service implementation available through this module, as you would expect, uses the Q version of the restler methods.