Eliminate HASH_DEFINE_OWN_STDINT #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This macro was introduced in 15ad042 for the benefit of people who were relying on "uthash.h" to define its own `uint8_t` and `uint32_t` typedefs, instead of either (1) getting them from the Standard Library or (2) getting them from the user-programmer somehow (e.g. `typedef char uint8_t` before including "uthash.h"). I see two projects using `HASH_NO_STDINT`, but zero projects using `HASH_DEFINE_OWN_STDINT`, and somehow five years have passed; it's time to kill off `HASH_DEFINE_OWN_STDINT`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro was introduced in 15ad042 for the benefit of people
who were relying on "uthash.h" to define its own
uint8_tanduint32_ttypedefs, instead of either (1) getting them from theStandard Library or (2) getting them from the user-programmer
somehow (e.g.
typedef char uint8_tbefore including "uthash.h").I see two projects using
HASH_NO_STDINT, but zero projectsusing
HASH_DEFINE_OWN_STDINT, and somehow five years have passed;it's time to kill off
HASH_DEFINE_OWN_STDINT.