Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-121069 / None / Add homebridge to community train #1034

Closed
wants to merge 15 commits into from

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Mar 16, 2023

  • App runs as root
  • auto device discovery uses mDNS. Which means

@stavros-k stavros-k added the jira label Mar 16, 2023
@stavros-k stavros-k self-assigned this Mar 16, 2023
@bugclerk bugclerk changed the title Add homebridge to community train NAS-121069 / None / Add homebridge to community train Mar 16, 2023
@bugclerk
Copy link
Contributor

@stavros-k stavros-k changed the base branch from common-fixes-improvements to master March 16, 2023 15:38
@stavros-k stavros-k force-pushed the homebridge-community branch 8 times, most recently from 748f0c6 to 68c57a4 Compare March 16, 2023 15:50
@stavros-k stavros-k changed the base branch from master to common-fixes-improvements March 16, 2023 15:51
@stavros-k stavros-k closed this Mar 16, 2023
@stavros-k stavros-k force-pushed the homebridge-community branch from 68c57a4 to 42145c0 Compare March 16, 2023 15:53
@stavros-k stavros-k reopened this Mar 16, 2023
@stavros-k stavros-k changed the base branch from common-fixes-improvements to master March 16, 2023 16:14
@stavros-k stavros-k closed this Mar 16, 2023
@stavros-k stavros-k force-pushed the homebridge-community branch from 6b208e9 to 929e60d Compare March 16, 2023 16:18
@stavros-k stavros-k reopened this Mar 16, 2023
@stavros-k stavros-k force-pushed the homebridge-community branch 4 times, most recently from 7fc4463 to 06c52f5 Compare March 20, 2023 14:48
@stavros-k stavros-k marked this pull request as ready for review March 20, 2023 16:17
@stavros-k stavros-k force-pushed the homebridge-community branch from 3b42f37 to 583faf6 Compare April 3, 2023 14:58
@Qubad786
Copy link
Contributor

Qubad786 commented Apr 4, 2023

@stavros-k is this up for review?

@stavros-k
Copy link
Contributor Author

@stavros-k is this up for review?

yes

@stavros-k stavros-k requested a review from Qubad786 April 4, 2023 06:53
@stavros-k
Copy link
Contributor Author

If it's gonna be expanded it might worth making it a bit more generic. As other apps might need to use mDNS in the future.

@anodos325
Copy link

anodos325 commented Apr 17, 2023

If it's gonna be expanded it might worth making it a bit more generic. As other apps might need to use mDNS in the future.

I'm okay with creating a db table for mDNS services and having our apps add what they need to it. This will generally be a better way of having some sanity here rather than doing a free-for-all.

@stavros-k
Copy link
Contributor Author

@Qubad786 Can we have an interface for that in a form of a $ref or something?

@stavros-k stavros-k force-pushed the homebridge-community branch from 010ac69 to 44ea3a5 Compare April 28, 2023 13:03
@stavros-k stavros-k changed the title NAS-121069 / None / Add homebridge to community train NAS-121069 / None / Add homebridge to community train May 1, 2023
@stavros-k stavros-k force-pushed the homebridge-community branch from dc62fb6 to f06bc03 Compare May 1, 2023 17:16
@yocalebo
Copy link
Contributor

yocalebo commented May 2, 2023

I've opened another ticket for this functionality to be added here: https://ixsystems.atlassian.net/browse/NAS-121784

@stavros-k stavros-k closed this May 29, 2023
@stavros-k stavros-k deleted the homebridge-community branch May 29, 2023 11:25
@stavros-k stavros-k restored the homebridge-community branch May 29, 2023 11:25
@stavros-k stavros-k deleted the homebridge-community branch September 16, 2024 20:38
@stavros-k stavros-k restored the homebridge-community branch September 16, 2024 20:38
@stavros-k stavros-k deleted the homebridge-community branch November 18, 2024 14:50
@stavros-k stavros-k restored the homebridge-community branch November 18, 2024 14:50
@stavros-k stavros-k deleted the homebridge-community branch November 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants