NAS-130088 / 25.04 / Allow taking snapshots of host paths associated with an app #15247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
requested changes
Dec 20, 2024
yocalebo
reviewed
Dec 26, 2024
| host_path_mapping = self.middleware.call_sync('app.get_hostpaths_datasets', app_info['name']) | ||
| # Stop the app itself before we attempt to take snapshots | ||
| self.middleware.call_sync('app.stop', app_info['name']).wait_sync() | ||
| if not snapshot_hostpath: |
There was a problem hiding this comment.
This if not snapshot_hostpath should be the first thing we do in this method, right? No reason to check all the other information if that's not provided since we return early.
yocalebo
requested changes
Dec 26, 2024
| mapping[host_path] = None | ||
|
|
||
| return mapping | ||
| return await self.middleware.call('zfs.dataset.paths_to_datasets', host_paths) |
There was a problem hiding this comment.
Your change is better, but it still uses a child process for every apps host-path. That's bad. Please see the changes I introduced in #15272. Once those are merged, you can call the paths_to_datasets_impl function directly. This does not use a child process and will be significantly faster/more efficient then what you're currently doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to allow taking snapshots of host paths associated with an app and also allowing them to rollback optionally.