NAS-133435 / 25.04 / Standardize vnc fields in virt instance update#15332
Merged
NAS-133435 / 25.04 / Standardize vnc fields in virt instance update#15332
Conversation
bugclerk
changed the title
Contributor
Qubad786
force-pushed
the
NAS-133435
branch
2 times, most recently
from
deaeec2 to
7c7b44e
Compare
yocalebo
requested changes
Jan 9, 2025
yocalebo
requested changes
Jan 9, 2025
Contributor
yocalebo
left a comment
yocalebo
left a comment
There was a problem hiding this comment.
Just making a comment here for posterity sake. If the user explicitly disables the VNC server, then we shouldn't validate the vnc_port attribute. If enable_vnc is False, then disable it and remove vnc_port (or ignore vnc_port).
Qubad786
force-pushed
the
NAS-133435
branch
3 times, most recently
from
2abb842 to
a4f9420
Compare
Qubad786
force-pushed
the
NAS-133435
branch
2 times, most recently
from
39e5d57 to
4e19c6a
Compare
yocalebo
approved these changes
Jan 13, 2025
yocalebo
reviewed
Jan 13, 2025
Contributor
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
UI requested that we standardize
virt.instance.updatesimilar to howvirt.instance.createworks and an explicitenable_vncfield has been added on that end forvirt.instance.updateto account for this.